FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: split parallel fs-watch-recursive tests by anonrig · Pull Request #45865 · nodejs/node · GitHub

/ node Public

test: split parallel fs-watch-recursive tests - #45865

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test.parallel/test-fs-watch-recursive
Dec 20, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: split parallel fs-watch-recursive tests#45865
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test.parallel/test-fs-watch-recursive

Conversation

anonrig commented Dec 14, 2022 •
edited by aduh95
Loading

Copy link
Copy Markdown
Member

Split test-fs-watch-recursive for a better understanding of the failing ones.

Fixes: #45535

CC @bnoordhuis

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 14, 2022
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022

nodejs-github-bot commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48488/

aduh95 reviewed Dec 14, 2022
View reviewed changes
Comment thread test/parallel/test-fs-watch-recursive-watch-file.js Outdated
Comment thread test/parallel/test-fs-watch-recursive-add-file-to-existing-subfolder.js Outdated
Comment thread test/parallel/test-fs-watch-recursive-add-file-to-new-folder.js Outdated
Comment thread test/parallel/test-fs-watch-recursive-add-file-with-url.js Outdated
Comment thread test/parallel/test-fs-watch-recursive-add-file.js Outdated
Comment thread test/parallel/test-fs-watch-recursive-add-folder.js Outdated
Comment thread test/parallel/test-fs-watch-recursive-watch-file.js Outdated
anonrig force-pushed the test.parallel/test-fs-watch-recursive branch from 194c82f to 6f81a76 Compare December 15, 2022 00:07
anonrig requested a review from aduh95 December 15, 2022 00:07
anonrig force-pushed the test.parallel/test-fs-watch-recursive branch from 6f81a76 to 00dbd16 Compare December 15, 2022 00:12
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2022

nodejs-github-bot commented Dec 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48492/

nodejs-github-bot commented Dec 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48502/

nodejs-github-bot commented Dec 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48532/

github-actions Bot mentioned this pull request Dec 17, 2022
Open
13 tasks

nodejs-github-bot commented Dec 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48538/

github-actions Bot mentioned this pull request Dec 18, 2022
Open
12 tasks

nodejs-github-bot commented Dec 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48553/

nodejs-github-bot commented Dec 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48563/

github-actions Bot mentioned this pull request Dec 19, 2022
Open
14 tasks

nodejs-github-bot commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48592/

lpinca approved these changes Dec 19, 2022
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

github-actions Bot mentioned this pull request Dec 20, 2022
Open
14 tasks

nodejs-github-bot commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48636/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2022
nodejs-github-bot merged commit 8398f85 into nodejs:main Dec 20, 2022

nodejs-github-bot commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8398f85

This was referenced Dec 21, 2022
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
test: split parallel fs-watch-recursive tests
e6da353 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
test: split parallel fs-watch-recursive tests
dd0ac7c 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
test: split parallel fs-watch-recursive tests
c6c0947 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
test: split parallel fs-watch-recursive tests
57e9ab1 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol mentioned this pull request Jan 28, 2023
Merged

juanarbol commented Jan 31, 2023

Copy link
Copy Markdown
Member

CI does not seem to like this for v18.x in Linux jobs, see https://ci.nodejs.org/job/node-test-pull-request/49261/

cheungxi pushed a commit to cheungxi/node that referenced this pull request Feb 1, 2023
test: split parallel fs-watch-recursive tests
fab102f 
PR-URL: nodejs#45865
Fixes: nodejs#45535
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test.parallel/test-fs-watch-recursive

7 participants

Back | FazBrowse Home | New Git URL