FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: enforce use of trailing commas in `tools/` by aduh95 · Pull Request #45889 · nodejs/node · GitHub

/ node Public

tools: enforce use of trailing commas in tools/ - #45889

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:tools-trailing-commas
Dec 18, 2022
Merged

tools: enforce use of trailing commas in tools/#45889
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:tools-trailing-commas

Conversation

aduh95 commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

Follow-up of #45471 and #45468.

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 16, 2022
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 16, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2022

Copy link
Copy Markdown
Collaborator

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 18, 2022
nodejs-github-bot merged commit 3ce4cef into nodejs:main Dec 18, 2022

Copy link
Copy Markdown
Collaborator

Landed in 3ce4cef

aduh95 deleted the tools-trailing-commas branch December 18, 2022 16:46
targos pushed a commit that referenced this pull request Jan 1, 2023
PR-URL: #45889
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS mentioned this pull request Jan 2, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45889
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #45889
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol mentioned this pull request Jan 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL