FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: update src/crypto/* in preparation for quic by jasnell · Pull Request #45912 · nodejs/node · GitHub

/ node Public

src: update src/crypto/* in preparation for quic - #45912

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:quic-preparation-crypto
ConversationCommits (3)ChecksFiles changed
Closed

src: update src/crypto/* in preparation for quic#45912
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:quic-preparation-crypto

Conversation

jasnell commented Dec 19, 2022

Copy link
Copy Markdown
Member

In preparation for use by the QUIC implementation, updates some pieces of src/crypto. These changes have been separated out of the larger quic PR (#44325) to make incremental review easier / possible.

/cc @bnoordhuis ... I've addressed the comments you had in #44325 here.

nodejs-github-bot commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 19, 2022
jasnell mentioned this pull request Dec 19, 2022
Closed
jasnell changed the title src: add GetCurrentCipherName/Version to crypto_common src: update src/crypto/* in preparation for quic Dec 19, 2022
jasnell force-pushed the quic-preparation-crypto branch from e4321c8 to 088c5f0 Compare December 19, 2022 21:31
addaleax reviewed Dec 19, 2022
View reviewed changes
Comment thread src/crypto/crypto_context.h Outdated
jasnell force-pushed the quic-preparation-crypto branch from 37ec12f to 64778c5 Compare December 20, 2022 00:15
jasnell requested a review from addaleax December 20, 2022 00:15
mcollina approved these changes Dec 20, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm on green CI

bnoordhuis approved these changes Dec 20, 2022
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Test failures are probably because of an inverted logical check.

Comment thread src/crypto/crypto_context.cc Outdated
jasnell force-pushed the quic-preparation-crypto branch from 64778c5 to 267a482 Compare December 20, 2022 19:06

This comment was marked as outdated.

Sign in to view
jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 20, 2022

nodejs-github-bot commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48685/

github-actions Bot mentioned this pull request Dec 22, 2022
Open
14 tasks
github-actions Bot mentioned this pull request Dec 23, 2022
Open
13 tasks

nodejs-github-bot commented Dec 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48719/

This was referenced Dec 24, 2022
Open
Open

nodejs-github-bot commented Dec 25, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48730/

This was referenced Dec 26, 2022
Open
Open

ronag commented Jan 19, 2023

Copy link
Copy Markdown
Member

Is anything stopping us from landing this?

jasnell commented Jan 20, 2023

Copy link
Copy Markdown
Member Author

Just time for me to get back to it. I'll rebase it tomorrow and do another CI run then will get it landed.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023

nodejs-github-bot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49129/

tniessen reviewed Jan 22, 2023
View reviewed changes
Comment thread src/crypto/crypto_context.h Outdated
src: add GetCurrentCipherName/Version to crypto_common
e33237b 
In preparation for use by the QUIC implementation.
src: add KeyObjectHandle::HasInstance
8c4bdea 
In preparation for use by the QUIC implementation.
src: add additional utilities to crypto::SecureContext
7b624da 
In preparation for use by the QUIC implementation.
jasnell force-pushed the quic-preparation-crypto branch from 267a482 to 7b624da Compare January 22, 2023 22:30

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49144/

aduh95 approved these changes Feb 3, 2023
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Feb 3, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2023

nodejs-github-bot commented Feb 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7079158...d523bfe

nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
src: add GetCurrentCipherName/Version to crypto_common
a689c4d 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
src: add KeyObjectHandle::HasInstance
c33c447 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
src: add additional utilities to crypto::SecureContext
d523bfe 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
src: add GetCurrentCipherName/Version to crypto_common
a8a2d0e 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
src: add KeyObjectHandle::HasInstance
efc59d0 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
src: add additional utilities to crypto::SecureContext
95065c3 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
src: add GetCurrentCipherName/Version to crypto_common
a639e2a 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
src: add KeyObjectHandle::HasInstance
92fdb24 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
src: add additional utilities to crypto::SecureContext
3aef68d 
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen left review comments
mcollina mcollina approved these changes
bnoordhuis bnoordhuis approved these changes
anonrig anonrig approved these changes
ronag ronag approved these changes
JungMinu JungMinu approved these changes
aduh95 aduh95 approved these changes
RafaelGSS RafaelGSS approved these changes
addaleax Awaiting requested review from addaleax

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL