FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use string_view for FastStringKey implementation by addaleax · Pull Request #45914 · nodejs/node · GitHub

/ node Public

src: use string_view for FastStringKey implementation - #45914

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
addaleax:faststringkey-stringview
Dec 21, 2022
ConversationCommits (3)ChecksFiles changed
Merged

src: use string_view for FastStringKey implementation#45914
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
addaleax:faststringkey-stringview

Conversation

addaleax commented Dec 19, 2022

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 19, 2022
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022

nodejs-github-bot commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48616/

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 19, 2022
legendecas reviewed Dec 20, 2022
View reviewed changes
Comment thread src/node_snapshotable.h Outdated
legendecas approved these changes Dec 20, 2022
View reviewed changes

legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2022

nodejs-github-bot commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48627/

nodejs-github-bot commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48644/

nodejs-github-bot commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48657/

github-actions Bot mentioned this pull request Dec 21, 2022
Open
12 tasks

nodejs-github-bot commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48668/

nodejs-github-bot commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48676/

nodejs-github-bot commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48677/

addaleax added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 21, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2022
nodejs-github-bot merged commit 1773b2a into nodejs:main Dec 21, 2022

nodejs-github-bot commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in 1773b2a

addaleax deleted the faststringkey-stringview branch December 21, 2022 22:49
This was referenced Dec 22, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 29, 2022
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
src: use string_view for FastStringKey implementation
192ca1a 
PR-URL: #45914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
src: use string_view for FastStringKey implementation
52eb054 
PR-URL: #45914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
src: use string_view for FastStringKey implementation
c2ed0cc 
PR-URL: #45914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
src: use string_view for FastStringKey implementation
0344dce 
PR-URL: #45914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
src: use string_view for FastStringKey implementation
9ca31cd 
PR-URL: #45914
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
anonrig anonrig approved these changes
tniessen tniessen approved these changes
legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL