FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix wrong output of example in `url.password` by deokjinkim · Pull Request #45928 · nodejs/node · GitHub

/ node Public

doc: fix wrong output of example in url.password - #45928

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:221221_fix_wrong_output_url_password
Dec 21, 2022
Merged

doc: fix wrong output of example in url.password#45928
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:221221_fix_wrong_output_url_password

Conversation

Copy link
Copy Markdown
Contributor

Tailing slash of url.href is ommited.

Tailing slash of url.href is ommited.
nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Dec 21, 2022
aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Dec 21, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2022
nodejs-github-bot merged commit f3dd3fe into nodejs:main Dec 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in f3dd3fe

targos pushed a commit that referenced this pull request Jan 1, 2023
Tailing slash of url.href is ommited.

PR-URL: #45928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
Tailing slash of url.href is ommited.

PR-URL: #45928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
Tailing slash of url.href is ommited.

PR-URL: #45928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
Tailing slash of url.href is ommited.

PR-URL: #45928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
Tailing slash of url.href is ommited.

PR-URL: #45928
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL