FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: update comment in `CODEOWNERS` to better reflect current policy by aduh95 · Pull Request #45944 · nodejs/node · GitHub

/ node Public

meta: update comment in CODEOWNERS to better reflect current policy - #45944

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:update-codeowners-comment
Jan 6, 2023
ConversationCommits (3)ChecksFiles changed
Merged

meta: update comment in CODEOWNERS to better reflect current policy#45944
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:update-codeowners-comment

Conversation

aduh95 commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

We do not enforce signing off by any code owners when landing PRs.

We may want to take the opportunity to refine our policy regarding CODEOWNERS and what are the criteria to consider a PR ready to land. Currently, here are the criteria listed in the Collaborator Guide:

node/doc/contributing/collaborator-guide.md

Lines 139 to 147 in 6831e2f

### Consensus seeking
A pull request can land if it has the needed [approvals](#code-reviews),
[CI](#testing-and-ci), [wait time](#waiting-for-approvals) and no
[outstanding objections](#objections). [Breaking changes](#breaking-changes)
must receive [TSC review](#involving-the-tsc) in addition to other
requirements. If a pull request meets all requirements except the
[wait time](#waiting-for-approvals), please add the
[`author ready`](#author-ready-pull-requests) label.

node/doc/contributing/collaborator-guide.md

Lines 122 to 129 in 6831e2f

At least two collaborators must approve a pull request before the pull request
lands. One collaborator approval is enough if the pull request has been open
for more than seven days.
Approving a pull request indicates that the collaborator accepts responsibility
for the change.
Approval must be from collaborators who are not authors of the change.

/cc @GeoffreyBooth @nodejs/tsc

meta: update comment in CODEOWNERS to better reflect current policy
ee6e881 
We do not enforce signing off by any code owners when landing PRs.

nodejs-github-bot commented Dec 22, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 22, 2022

GeoffreyBooth commented Dec 22, 2022

Copy link
Copy Markdown
Member

Rather than restate the policy from the collaborator guide, perhaps this comment should just link to it?

RaisinTen approved these changes Dec 23, 2022
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I agree with @GeoffreyBooth, doc/contributing/collaborator-guide.md is a much better place for this info because all collaborators are familiar with it. I don't think many collaborators will look at comments in a GitHub specific file for our policies.

GeoffreyBooth reviewed Dec 26, 2022
View reviewed changes
Comment thread .github/CODEOWNERS Outdated
Update .github/CODEOWNERS
210d7a6 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
GeoffreyBooth added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 28, 2022

aduh95 commented Dec 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've added a few additional changes which after giving it a few thoughts, I think should belong in this PR:

  • I've removed the ordered list, AFAICT there was no particular order in the list.
  • I've removed the point that says "Each codeowner team should contain at least one @nodejs/tsc member" because I believe we do not enforce this either.

PTAL if you already approved the PR, and consider re-approving if you agree with that new change.

aduh95 removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 28, 2022
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 1, 2023
mhdawson approved these changes Jan 3, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 6, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2023
nodejs-github-bot merged commit 6f50acd into nodejs:main Jan 6, 2023

nodejs-github-bot commented Jan 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6f50acd

aduh95 deleted the update-codeowners-comment branch January 6, 2023 09:57
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
meta: update comment in CODEOWNERS to better reflect current policy
20d76d8 
We do not enforce signing off by any code owners when landing PRs.

PR-URL: nodejs#45944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
meta: update comment in CODEOWNERS to better reflect current policy
1b557bb 
We do not enforce signing off by any code owners when landing PRs.

PR-URL: #45944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
meta: update comment in CODEOWNERS to better reflect current policy
08a9bf8 
We do not enforce signing off by any code owners when landing PRs.

PR-URL: #45944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
meta: update comment in CODEOWNERS to better reflect current policy
d8ce990 
We do not enforce signing off by any code owners when landing PRs.

PR-URL: #45944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GeoffreyBooth GeoffreyBooth approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
joyeecheung joyeecheung approved these changes
BethGriggs BethGriggs approved these changes
legendecas legendecas approved these changes
RaisinTen RaisinTen approved these changes
+2 more reviewers
danielleadams danielleadams approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL