FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

buffer: add buffer.isUtf8 for utf8 validation by anonrig · Pull Request #45947 · nodejs/node · GitHub

/ node Public

buffer: add buffer.isUtf8 for utf8 validation - #45947

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
anonrig:feat/add-is-utf8
Dec 25, 2022
ConversationCommits (6)ChecksFiles changed
Merged

buffer: add buffer.isUtf8 for utf8 validation#45947
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
anonrig:feat/add-is-utf8

Conversation

anonrig commented Dec 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

With the introduction of simdutf, we can finally have a fast way of validating utf-8 on the userland. This pull request introduces buffer.isUtf8.

This was initially requested by @KhafraDev while implementing undici websockets.

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 22, 2022
anonrig mentioned this pull request Dec 22, 2022
Closed
4 tasks

anonrig commented Dec 22, 2022

Copy link
Copy Markdown
Member Author

CC @nodejs/buffer @nodejs/performance @nodejs/undici

lpinca reviewed Dec 22, 2022
View reviewed changes
Comment thread lib/buffer.js Outdated
RafaelGSS reviewed Dec 22, 2022
View reviewed changes
Comment thread src/node_buffer.cc Outdated
KhafraDev reviewed Dec 22, 2022
View reviewed changes
Comment thread lib/buffer.js Outdated

targos commented Dec 23, 2022

Copy link
Copy Markdown
Member

Can you add a test with a detached array buffer ?

lpinca reviewed Dec 23, 2022
View reviewed changes
Comment thread doc/api/buffer.md Outdated
lpinca reviewed Dec 23, 2022
View reviewed changes
Comment thread lib/buffer.js Outdated
mcollina approved these changes Dec 23, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

bnoordhuis reviewed Dec 23, 2022
View reviewed changes
Comment thread src/node_buffer.cc Outdated
Comment thread test/parallel/test-buffer-isutf8.js Outdated
anonrig requested review from KhafraDev, RafaelGSS, bnoordhuis, lpinca and targos and removed request for KhafraDev December 23, 2022 17:34
anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. notable-change PRs with changes that should be highlighted in changelogs. labels Dec 23, 2022
lpinca approved these changes Dec 23, 2022
View reviewed changes
Comment thread test/parallel/test-buffer-isutf8.js Outdated
Comment thread test/parallel/test-buffer-isutf8.js Outdated
Comment thread test/parallel/test-buffer-isutf8.js Outdated
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2022
github-actions Bot mentioned this pull request Jan 2, 2023
Open
22 tasks
RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS added a commit that referenced this pull request Jan 2, 2023
2023-01-03, Version 19.4.0 (Current)
fd77454 
Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
deps:
  * disable avx512 for simutf on benchmark ci (Yagiz Nizipli) #45803
  * add simdutf dependency (Yagiz Nizipli) #45803
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46061
RafaelGSS added a commit that referenced this pull request Jan 2, 2023
2023-01-03, Version 19.4.0 (Current)
3d55e4b 
Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
deps:
  * disable avx512 for simutf on benchmark ci (Yagiz Nizipli) #45803
  * add simdutf dependency (Yagiz Nizipli) #45803
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46061
github-actions Bot mentioned this pull request Jan 3, 2023
Open
23 tasks
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
buffer: add buffer.isUtf8 for utf8 validation
fd33718 
PR-URL: #45947
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS added a commit that referenced this pull request Jan 4, 2023
2023-01-05, Version 19.4.0 (Current)
790cc5b 
Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46061
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
buffer: add buffer.isUtf8 for utf8 validation
fbe399c 
PR-URL: #45947
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS added a commit that referenced this pull request Jan 5, 2023
2023-01-05, Version 19.4.0 (Current)
b181545 
Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46061
RafaelGSS added a commit that referenced this pull request Jan 5, 2023
2023-01-06, Version 19.4.0 (Current)
e58ed6d 
Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46061
RafaelGSS added a commit that referenced this pull request Jan 6, 2023
2023-01-06, Version 19.4.0 (Current)
22a2ec6 
Notable changes:

buffer:
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
http:
  * (SEMVER-MINOR) improved timeout defaults handling (Paolo Insogna) #45778
net
  * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
os:
  * (SEMVER-MINOR) add availableParallelism() (Colin Ihrig) #45895
util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46061
bentley1985 reviewed Jan 7, 2023
View reviewed changes

bentley1985 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

juanarbol pushed a commit that referenced this pull request Jan 26, 2023
buffer: add buffer.isUtf8 for utf8 validation
907068c 
PR-URL: #45947
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol added a commit that referenced this pull request Jan 28, 2023
2023-01-31, Version 18.14.0 'Hydrogen' (LTS)
614a60d 
Notable changes:

* buffer
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
* deps:
  * disable avx512 for simutf on benchmark ci (Yagiz Nizipli) #45803
  * add simdutf dependency (Yagiz Nizipli) #45803
  * upgrade npm to 9.1.3 (npm team) #45693
* util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46396
juanarbol added a commit that referenced this pull request Jan 30, 2023
2023-01-31, Version 18.14.0 'Hydrogen' (LTS)
53ddd3a 
Notable changes:

* buffer
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
* deps:
  * add simdutf dependency (Yagiz Nizipli) #45803
  * upgrade npm to 9.1.3 (npm team) #45693
* util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46396
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
buffer: add buffer.isUtf8 for utf8 validation
16ee02f 
PR-URL: #45947
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
juanarbol added a commit that referenced this pull request Jan 31, 2023
2023-01-31, Version 18.14.0 'Hydrogen' (LTS)
a413280 
Notable changes:

* buffer
  * (SEMVER-MINOR) add buffer.isUtf8 for utf8 validation (Yagiz Nizipli) #45947
* deps:
  * add simdutf dependency (Yagiz Nizipli) #45803
  * upgrade npm to 9.1.3 (npm team) #45693
* util:
  * add fast path for text-decoder fatal flag (Yagiz Nizipli) #45803

PR-URL: #46396
BethGriggs mentioned this pull request Feb 3, 2023
Closed
Archkon mentioned this pull request Jul 14, 2026
Closed
coderabbitai Bot mentioned this pull request Aug 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lemire lemire left review comments
jasnell jasnell left review comments
lpinca lpinca approved these changes
KhafraDev KhafraDev left review comments
mcollina mcollina approved these changes
addaleax addaleax approved these changes
ronag ronag approved these changes
RafaelGSS RafaelGSS approved these changes
targos Awaiting requested review from targos
bnoordhuis Awaiting requested review from bnoordhuis
+1 more reviewer
bentley1985 bentley1985 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL