FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "deps: disable avx512 for simutf on benchmark ci" by anonrig · Pull Request #45948 · nodejs/node · GitHub

/ node Public

Revert "deps: disable avx512 for simutf on benchmark ci" - #45948

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:disable/avx512-opt
Dec 24, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Revert "deps: disable avx512 for simutf on benchmark ci"#45948
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:disable/avx512-opt

Conversation

anonrig commented Dec 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This is no longer needed. Benchmark CI is now running Ubuntu 18.04. Referencing nodejs/build#3122

CC @nodejs/build

nodejs-github-bot commented Dec 22, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 22, 2022

anonrig commented Dec 22, 2022

Copy link
Copy Markdown
Member Author

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1277/

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2022

nodejs-github-bot commented Dec 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48702/

github-actions Bot mentioned this pull request Dec 23, 2022
Open
13 tasks

nodejs-github-bot commented Dec 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48705/

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 23, 2022
github-actions Bot mentioned this pull request Dec 24, 2022
Open
12 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 24, 2022
nodejs-github-bot merged commit 07fdbbd into nodejs:main Dec 24, 2022

nodejs-github-bot commented Dec 24, 2022

Copy link
Copy Markdown
Collaborator

Landed in 07fdbbd

This was referenced Dec 25, 2022
Open
Open
Open
Open
Open
Open
Open
github-actions Bot mentioned this pull request Jan 1, 2023
Open
20 tasks
targos pushed a commit that referenced this pull request Jan 1, 2023
Revert "deps: disable avx512 for simutf on benchmark ci"
fd7561e 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request Jan 2, 2023
Open
22 tasks
RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
Revert "deps: disable avx512 for simutf on benchmark ci"
b181726 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
Revert "deps: disable avx512 for simutf on benchmark ci"
05fee67 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
Revert "deps: disable avx512 for simutf on benchmark ci"
cb767a2 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
Revert "deps: disable avx512 for simutf on benchmark ci"
4063cdc 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL