FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use `os.availableParallelism()` by deokjinkim · Pull Request #46003 · nodejs/node · GitHub

/ node Public

test: use os.availableParallelism() - #46003

Closed
deokjinkim wants to merge 2 commits into
nodejs:mainfrom
deokjinkim:221229_use_availableParallelism_in_test
ConversationCommits (2)ChecksFiles changed
Closed

test: use os.availableParallelism()#46003
deokjinkim wants to merge 2 commits into
nodejs:mainfrom
deokjinkim:221229_use_availableParallelism_in_test

Conversation

deokjinkim commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

Refs: #45895

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 29, 2022
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023

nodejs-github-bot commented Jan 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48776/

github-actions Bot mentioned this pull request Jan 2, 2023
Open
22 tasks
This was referenced Jan 2, 2023
Closed
Closed
This was referenced Jan 3, 2023
Open
Open

nodejs-github-bot commented Jan 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48848/

github-actions Bot mentioned this pull request Jan 5, 2023
Open
22 tasks
lpinca added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jan 10, 2023

lpinca commented Jan 10, 2023

Copy link
Copy Markdown
Member

@deokjinkim can you please fix the second commit message?

deokjinkim force-pushed the 221229_use_availableParallelism_in_test branch from fe746dd to 35a551e Compare January 11, 2023 01:14

deokjinkim commented Jan 11, 2023

Copy link
Copy Markdown
Contributor Author

@deokjinkim can you please fix the second commit message?

@lpinca Updated the second commit message. Thank you for feedback.

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46003
✔  Done loading data for nodejs/node/pull/46003
----------------------------------- PR info ------------------------------------
Title      test: use `os.availableParallelism()` (#46003)
Author     Deokjin Kim  (@deokjinkim)
Branch     deokjinkim:221229_use_availableParallelism_in_test -> nodejs:main
Labels     test, needs-ci, commit-queue-rebase
Commits    2
 - test: use `os.availableParallelism()`
 - benchmark,tools: use os.availableParallelism()
Committers 1
 - Deokjin Kim 
PR-URL: https://github.com/nodejs/node/pull/46003
Refs: https://github.com/nodejs/node/pull/45895
Reviewed-By: Moshe Atlow 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46003
Refs: https://github.com/nodejs/node/pull/45895
Reviewed-By: Moshe Atlow 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test: use `os.availableParallelism()`
   ⚠  - benchmark,tools: use os.availableParallelism()
   ℹ  This PR was created on Thu, 29 Dec 2022 01:40:27 GMT
   ✔  Approvals: 4
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/46003#pullrequestreview-1232434448
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46003#pullrequestreview-1232536045
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46003#pullrequestreview-1232761012
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46003#pullrequestreview-1233497702
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-01-04T21:04:34Z: https://ci.nodejs.org/job/node-test-pull-request/48848/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - test: use `os.availableParallelism()`
   ⚠  - benchmark,tools: use os.availableParallelism()
- Querying data for job/node-test-pull-request/48848/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3896223776

lpinca removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 11, 2023
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in b39c3f6...a9bc3cf

nodejs-github-bot pushed a commit that referenced this pull request Jan 11, 2023
test: use os.availableParallelism()
d8014f6 
Refs: #45895
PR-URL: #46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot pushed a commit that referenced this pull request Jan 11, 2023
benchmark,tools: use os.availableParallelism()
a9bc3cf 
Refs: #45895
PR-URL: #46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
test: use os.availableParallelism()
897daf9 
Refs: nodejs#45895
PR-URL: nodejs#46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
benchmark,tools: use os.availableParallelism()
b041e8d 
Refs: nodejs#45895
PR-URL: nodejs#46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
test: use os.availableParallelism()
6e2f722 
Refs: #45895
PR-URL: #46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
benchmark,tools: use os.availableParallelism()
e1c56ec 
Refs: #45895
PR-URL: #46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
test: use os.availableParallelism()
0009faa 
Refs: #45895
PR-URL: #46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
benchmark,tools: use os.availableParallelism()
b3802b2 
Refs: #45895
PR-URL: #46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
test: use os.availableParallelism()
257224d 
Refs: #45895
PR-URL: #46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
benchmark,tools: use os.availableParallelism()
ed1ac82 
Refs: #45895
PR-URL: #46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
MoLow MoLow approved these changes

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL