FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: add CryptoKey Symbol.toStringTag by panva · Pull Request #46042 · nodejs/node · GitHub

/ node Public

crypto: add CryptoKey Symbol.toStringTag - #46042

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:add-cryptokey-toStringTag
Jan 18, 2023
ConversationCommits (1)ChecksFiles changed
Merged

crypto: add CryptoKey Symbol.toStringTag#46042
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:add-cryptokey-toStringTag

Conversation

panva commented Jan 1, 2023 •
edited by aduh95
Loading

Copy link
Copy Markdown
Member

Adds Symbol.toStringTag getter to CryptoKey to match other implementations behaviour.

Fixes: #45987

panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Jan 1, 2023

nodejs-github-bot commented Jan 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 1, 2023
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
panva force-pushed the add-cryptokey-toStringTag branch from 7ea1625 to e604769 Compare January 1, 2023 14:26

This comment was marked as outdated.

Sign in to view
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 1, 2023

nodejs-github-bot commented Jan 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48787/

panva mentioned this pull request Jan 1, 2023
Merged
panva added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 1, 2023
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 1, 2023
github-actions Bot mentioned this pull request Jan 2, 2023
Open
22 tasks

bnoordhuis commented Jan 2, 2023

Copy link
Copy Markdown
Member

I'd hold off on merging until web-platform-tests/wpt#37716 is accepted (and maybe wait a few days in case it gets reverted again.)

panva commented Jan 2, 2023

Copy link
Copy Markdown
Member Author

I'd hold off on merging until web-platform-tests/wpt#37716 is accepted (and maybe wait a few days in case it gets reverted again.)

Why? This is a QoL change that's not contradicting any existing requirement and aligns with other implementer's behaviour.

Even if the WPT wouldn't get updated it won't be for its incorrectness but rather its lack of being a requirement.

bnoordhuis commented Jan 2, 2023

Copy link
Copy Markdown
Member

On the off chance that the WPT people raise valid concerns about the change. It's not a break-the-world kind of bug so I'd advise against rushing out a fix.

panva commented Jan 2, 2023

Copy link
Copy Markdown
Member Author

On the off chance that the WPT people raise valid concerns about the change. It's not a break-the-world kind of bug so I'd advise against rushing out a fix.

Fine. I disagree with holding off just for the record because any valid concern would go against years of existing browser implementors having this behaviour and unlikely to be met with browser vendors' support to change.

panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 2, 2023
juanarbol approved these changes Jan 2, 2023
View reviewed changes

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

github-actions Bot mentioned this pull request Jan 3, 2023
Open
23 tasks
aduh95 added the blocked PRs that are blocked by other issues or PRs. label Jan 3, 2023
This was referenced Jan 4, 2023
Open
Open

panva commented Jan 18, 2023

Copy link
Copy Markdown
Member Author

All browsers, Deno, Bun, even widely used polyfills like PeculiarVentures/webcrypto yield the same result.

IMO there's no point in waiting for WPTs to be updated. Even if they weren't updated because for some reason this does not fall under what WPTs should be checking, we'd still have no reason for misalignment.

panva commented Jan 18, 2023

Copy link
Copy Markdown
Member Author

WPT was merged protest-free.

panva added commit-queue Add this label to land a pull request using GitHub Actions. and removed blocked PRs that are blocked by other issues or PRs. labels Jan 18, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2023
nodejs-github-bot merged commit 13f518f into nodejs:main Jan 18, 2023

nodejs-github-bot commented Jan 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in 13f518f

panva deleted the add-cryptokey-toStringTag branch January 18, 2023 18:07
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
crypto: add CryptoKey Symbol.toStringTag
8b22310 
closes #45987

PR-URL: #46042
Fixes: #45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
RafaelGSS mentioned this pull request Jan 20, 2023
Merged
RafaelGSS added a commit that referenced this pull request Jan 20, 2023
2023-01-24, Version 19.5.0 (Current)
ecb598d 
Notable changes:

* crypto:
  * (SEMVER-MINOR) add CryptoKey Symbol.toStringTag (Filip Skokan) [#46042](#46042)
  * (SEMVER-MINOR) add KeyObject Symbol.toStringTag (Filip Skokan) [#46043](#46043)
* http:
  * (SEMVER-MINOR) join authorization headers (Marco Ippolito) [#45982](#45982)
* lib:
  * add webstreams to Duplex.from() (Debadree Chatterjee) [#46190](#46190)
* stream:
  * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) [#46205](#46205)

PR-URL: #46286
panva mentioned this pull request Jan 24, 2023
Closed
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
crypto: add CryptoKey Symbol.toStringTag
8166ff9 
closes #45987

PR-URL: #46042
Fixes: #45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol pushed a commit to panva/node that referenced this pull request Jan 28, 2023
crypto: add CryptoKey Symbol.toStringTag
1a3cd21 
closes nodejs#45987

PR-URL: nodejs#46042
Backport-PR-URL: nodejs#46340
Fixes: nodejs#45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
crypto: add CryptoKey Symbol.toStringTag
52a7887 
closes #45987

PR-URL: #46042
Fixes: #45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
panva mentioned this pull request Mar 31, 2023
Closed
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
crypto: add CryptoKey Symbol.toStringTag
bc17568 
closes nodejs#45987

PR-URL: nodejs#46042
Fixes: nodejs#45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Backport-PR-URL: nodejs#47336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
aduh95 aduh95 approved these changes
juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CryptoKey string tag imprecise for detection

6 participants

Back | FazBrowse Home | New Git URL