tools: make update-eslint.sh work with npm@9 - #46088
Closed
lpinca wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
commented
Jan 4, 2023
Comment thread
tools/update-eslint.sh
Outdated
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
The --global-style option has been deprecated in favor of --install-strategy=shallow.
Sorry, something went wrong.
Comment thread
tools/update-eslint.sh
Outdated
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
The default value has been flipped.
Sorry, something went wrong.
Comment thread
tools/update-eslint.sh
Outdated
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Ditto.
Sorry, something went wrong.
Comment thread
tools/update-eslint.sh
Outdated
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I'm not sure why but an ENOENT error is raised with the original command.
Sorry, something went wrong.
lpinca
force-pushed
the
fix/update-eslint-script
branch
from
dc78120 to
975aeff
Compare
January 4, 2023 09:19
ruyadorno
approved these changes
Jan 4, 2023
Copy link
Copy Markdown
Member
Author
|
I did not see #45974 but it seems it does not include the --install-links change, and it fails without it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
My PR works FWIW (yes even without --install-links), but I like yours better. Would you consider moving the script to tools/dep_updaters? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
It did not work on WSL (Ubuntu 22.04). I don't have access to it at the moment, but I can test again tomorrow.
Yes, I can add a commit for it. I will do it later. |
Sorry, something went wrong.
lpinca
force-pushed
the
fix/update-eslint-script
branch
from
975aeff to
e78ebf0
Compare
January 4, 2023 19:56
Make the `update-eslint.sh` script work with `npm@9`.
Move the `update-eslint.sh` script to the `dep_updaters/` directory.
lpinca
force-pushed
the
fix/update-eslint-script
branch
from
e78ebf0 to
9766106
Compare
January 4, 2023 20:35
aduh95
approved these changes
Jan 4, 2023
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
Make the `update-eslint.sh` script work with `npm@9`. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
Move the `update-eslint.sh` script to the `dep_updaters/` directory. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
Make the `update-eslint.sh` script work with `npm@9`. PR-URL: nodejs#46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
Move the `update-eslint.sh` script to the `dep_updaters/` directory. PR-URL: nodejs#46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Make the `update-eslint.sh` script work with `npm@9`. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Move the `update-eslint.sh` script to the `dep_updaters/` directory. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Make the `update-eslint.sh` script work with `npm@9`. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Move the `update-eslint.sh` script to the `dep_updaters/` directory. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Make the `update-eslint.sh` script work with `npm@9`. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Move the `update-eslint.sh` script to the `dep_updaters/` directory. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the update-eslint.sh script work with npm@9.
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64