doc: include updating release optional step - #46089
Conversation
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
There was a problem hiding this comment.
I think it'd be useful to have the Git steps documented in this section for when we need to remove or adjust commits in the release. As a draft suggestion, I think including steps like this would be useful:
Remove or adjust problematic commit(s):
# update staging git checkout staging git rebase -i ... # rebase to drop or edit the bad commit(s) git push -f upstream staging # rebase proposal against the updated staging branch git checkout proposal git rebase upstream/staging
Reminder to re-run changelog-maker and update the changelog to include the new/changed Git SHAs. (Easily forgotten).
Sorry, something went wrong.
There was a problem hiding this comment.
Just updated
Sorry, something went wrong.
There was a problem hiding this comment.
Actually, it's missing a fix. In case of dropping a commit, we need to reset the branch instead of rebasing
git reset --hard upstream/staging
I'll adjust it.
Sorry, something went wrong.
There was a problem hiding this comment.
Done!
Sorry, something went wrong.
PR-URL: nodejs#46089 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
PR-URL: #46089 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
PR-URL: #46089 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
PR-URL: #46089 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
cc @nodejs/releasers