FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: return correct bit length in KeyObject's asymmetricKeyDetails by panva · Pull Request #46106 · nodejs/node · GitHub

/ node Public

crypto: return correct bit length in KeyObject's asymmetricKeyDetails - #46106

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:fix-details-bitlenghts
Jan 7, 2023
ConversationCommits (1)ChecksFiles changed
Merged

crypto: return correct bit length in KeyObject's asymmetricKeyDetails#46106
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:fix-details-bitlenghts

Conversation

panva commented Jan 5, 2023

Copy link
Copy Markdown
Member

Our KeyObject details incorrectly ceil bit lengths to the nearest multiple of 8.

panva added the crypto Issues and PRs related to the crypto subsystem. label Jan 5, 2023

nodejs-github-bot commented Jan 5, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 5, 2023
panva force-pushed the fix-details-bitlenghts branch from 14bf4c3 to 00811fa Compare January 5, 2023 13:09
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2023

This comment was marked as outdated.

Sign in to view
panva mentioned this pull request Jan 5, 2023
Closed
panva force-pushed the fix-details-bitlenghts branch from 00811fa to c4cee3e Compare January 5, 2023 15:18

nodejs-github-bot commented Jan 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48864/

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 5, 2023
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2023
nodejs-github-bot merged commit 021f726 into nodejs:main Jan 7, 2023

nodejs-github-bot commented Jan 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in 021f726

panva deleted the fix-details-bitlenghts branch January 7, 2023 13:20
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
crypto: return correct bit length in KeyObject's asymmetricKeyDetails
a8c8a48 
PR-URL: nodejs#46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
crypto: return correct bit length in KeyObject's asymmetricKeyDetails
1146f02 
PR-URL: #46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
crypto: return correct bit length in KeyObject's asymmetricKeyDetails
1d0b562 
PR-URL: #46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
crypto: return correct bit length in KeyObject's asymmetricKeyDetails
24a1016 
PR-URL: #46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
alaczi mentioned this pull request Mar 14, 2023
Open

sigalsMelio commented Nov 21, 2023

Copy link
Copy Markdown

I am trying to understand in what version this is fixed, I cannot find it in release notes. We are experiencing this issue in 18.18.2

panva commented Nov 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

I am trying to understand in what version this is fixed, I cannot find it in release notes. We are experiencing this issue in 18.18.2

It was first released in v19.15.0 and backported to v18.x with v18.14.0

sigalsMelio commented Nov 21, 2023

Copy link
Copy Markdown

I am trying to understand in what version this is fixed, I cannot find it in release notes. We are experiencing this issue in 18.18.2

It was first released in v19.15.0 and backported to v18.x with v18.14.0

Thank you @panva , I don't know why it still happens then

tniessen commented Nov 21, 2023

Copy link
Copy Markdown
Member

@sigalsMelio Could you please open a new issue with a description and reproduction if possible?

sigalsMelio commented Nov 21, 2023

Copy link
Copy Markdown

@tniessen trying to figure out whether it's something I need to resolve with jsonwebtoken

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL