doc: fix (EC)DHE remark in TLS docs - #46114
Merged
nodejs-github-bot merged 1 commit intoJan 8, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
It is not true that all TLS 1.3 cipher suites use ECDH. TLS 1.3 allows DH over finite fields instead of elliptic curves. Also, the key exchange mechanism is independent of the cipher suite in TLS 1.3.
bnoordhuis
approved these changes
Jan 6, 2023
lpinca
approved these changes
Jan 7, 2023
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
It is not true that all TLS 1.3 cipher suites use ECDH. TLS 1.3 allows DH over finite fields instead of elliptic curves. Also, the key exchange mechanism is independent of the cipher suite in TLS 1.3. PR-URL: nodejs#46114 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
It is not true that all TLS 1.3 cipher suites use ECDH. TLS 1.3 allows DH over finite fields instead of elliptic curves. Also, the key exchange mechanism is independent of the cipher suite in TLS 1.3. PR-URL: #46114 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
It is not true that all TLS 1.3 cipher suites use ECDH. TLS 1.3 allows DH over finite fields instead of elliptic curves. Also, the key exchange mechanism is independent of the cipher suite in TLS 1.3. PR-URL: #46114 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
It is not true that all TLS 1.3 cipher suites use ECDH. TLS 1.3 allows DH over finite fields instead of elliptic curves. Also, the key exchange mechanism is independent of the cipher suite in TLS 1.3. PR-URL: #46114 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not true that all TLS 1.3 cipher suites use ECDH.
TLS 1.3 allows DH over finite fields instead of elliptic curves. Also, the key exchange mechanism is independent of the cipher suite in TLS 1.3.