test: add test to once() in event lib - #46126
Merged
nodejs-github-bot merged 1 commit intoJan 9, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
panva
reviewed
Jan 7, 2023
Comment thread
test/parallel/test-events-once.js
Outdated
panva
reviewed
Jan 7, 2023
panva
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please update the first commit message. It should not end with punctuation.
Sorry, something went wrong.
Comment thread
test/parallel/test-events-once.js
Outdated
Copy link
Copy Markdown
Member
While you're at, make the first word imperative mood. Maybe this?: test: add test to once() method in the event lib |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This test verify if eventEmmiter param is right
Trott
force-pushed
the
jonathanDiaz/adding-test-to-event-lib
branch
from
7e5e9fc to
187b5a3
Compare
January 7, 2023 23:18
anonrig
approved these changes
Jan 8, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
panva
approved these changes
Jan 8, 2023
Copy link
Copy Markdown
Member
|
@jdiaz-dev thank you for your first contribution. Barring any objections from other collaborators your PR will automatically land on the main branch after it's been open for 48 hours. |
Sorry, something went wrong.
This was referenced Jan 11, 2023
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
This test verify if eventEmmiter param is right PR-URL: nodejs#46126 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
This test verify if eventEmmiter param is right PR-URL: #46126 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
This test verify if eventEmmiter param is right PR-URL: #46126 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
This test verify if eventEmmiter param is right PR-URL: #46126 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test verify if eventEmmiter param is right in once method