tools: add automation for updating postject dependency - #46157
Merged
nodejs-github-bot merged 3 commits intoJan 14, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
tony-go
reviewed
Jan 10, 2023
Comment thread
.github/workflows/tools.yml
tony-go
approved these changes
Jan 10, 2023
aduh95
reviewed
Jan 10, 2023
Comment thread
.github/workflows/tools.yml
Outdated
aduh95
reviewed
Jan 10, 2023
Comment thread
doc/contributing/maintaining-postject.md
Outdated
Refs: nodejs#46157 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
Refs: nodejs#46157 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
aduh95
approved these changes
Jan 12, 2023
aymen94
approved these changes
Jan 13, 2023
mhdawson
approved these changes
Jan 13, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@facutuesca if you have a change to review as well that would be good. |
Sorry, something went wrong.
This comment was marked as outdated.
19 tasks
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jan 15, 2023
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Jan 18, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @nodejs/single-executable