FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src,lib: the handle keeps loop alive in cluster rr mode by theanarkh · Pull Request #46161 · nodejs/node · GitHub

/ node Public

src,lib: the handle keeps loop alive in cluster rr mode - #46161

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:keep_loop_alive_in_cluster_shared_mode
Jan 16, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src,lib: the handle keeps loop alive in cluster rr mode#46161
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:keep_loop_alive_in_cluster_shared_mode

Conversation

theanarkh commented Jan 10, 2023 •
edited by VoltrexKeyva
Loading

Copy link
Copy Markdown
Contributor

The handle does not keep loop alive in cluster rr mode, the code is as follows.

const http = require('http');
const cluster = require('cluster');
cluster.schedulingPolicy = cluster.SCHED_RR;

if (cluster.isMaster) {
    cluster.fork();
} else {
    http.createServer((req, res) => {
        res.end('ok');
    }).listen(8888, () => {
        process.channel.unref();
    });
}

So try to fix this issue.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 10, 2023
bnoordhuis reviewed Jan 10, 2023
View reviewed changes
Comment thread lib/internal/cluster/child.js Outdated
Comment thread src/node_util.cc Outdated
theanarkh force-pushed the keep_loop_alive_in_cluster_shared_mode branch 2 times, most recently from 4eeac79 to b93fc9c Compare January 11, 2023 16:09
bnoordhuis approved these changes Jan 11, 2023
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM (improves on the existing state of things) but see comment.

Comment thread lib/internal/cluster/child.js Outdated
theanarkh force-pushed the keep_loop_alive_in_cluster_shared_mode branch from b93fc9c to 934837c Compare January 12, 2023 00:29
theanarkh force-pushed the keep_loop_alive_in_cluster_shared_mode branch from 934837c to c1486d4 Compare January 12, 2023 16:20
theanarkh force-pushed the keep_loop_alive_in_cluster_shared_mode branch from c1486d4 to 415cbe7 Compare January 12, 2023 16:24
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023

nodejs-github-bot commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48959/

nodejs-github-bot commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48961/

theanarkh added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 13, 2023
jasnell reviewed Jan 13, 2023
View reviewed changes
Comment thread lib/internal/cluster/child.js
This was referenced Jan 14, 2023
Open
Open
Open
theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 16, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 16, 2023
nodejs-github-bot merged commit 7895484 into nodejs:main Jan 16, 2023

nodejs-github-bot commented Jan 16, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7895484

github-actions Bot mentioned this pull request Jan 17, 2023
Open
17 tasks
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
src,lib: the handle keeps loop alive in cluster rr mode
d9c9cdc 
PR-URL: nodejs#46161
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
github-actions Bot mentioned this pull request Jan 18, 2023
Open
18 tasks
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
src,lib: the handle keeps loop alive in cluster rr mode
5cf5956 
PR-URL: #46161
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
src,lib: the handle keeps loop alive in cluster rr mode
aebdef8 
PR-URL: #46161
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
src,lib: the handle keeps loop alive in cluster rr mode
08a6a61 
PR-URL: #46161
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
github-actions Bot mentioned this pull request Apr 24, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
addaleax addaleax left review comments
bnoordhuis bnoordhuis approved these changes
JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL