deps: upgrade npm to 9.3.0 - #46193
Merged
nodejs-github-bot merged 2 commits intoJan 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@ljharb does npm/cli@cf175fb resolve your issue? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@targos no - that allows me to do npm --otp, which is a good bug fix, but if i do npm publish with no other config, i expect to be prompted for an OTP. npm 9 instead sends me to a web browser to do webauthn. My issue is that that "auth-type" change is breaking, on all extant node release lines. |
Sorry, something went wrong.
lpinca
approved these changes
Jan 13, 2023
tniessen
approved these changes
Jan 13, 2023
gengjiawen
approved these changes
Jan 15, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46193 ✔ Done loading data for nodejs/node/pull/46193 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 9.3.0 (#46193) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-cli-bot:npm-v9.3.0 -> nodejs:main Labels npm, fast-track, needs-ci, dont-land-on-v14.x Commits 1 - deps: upgrade npm to 9.3.0 Committers 1 - npm CLI robot PR-URL: https://github.com/nodejs/node/pull/46193 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46193 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Jiawen Geng -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 12 Jan 2023 20:43:26 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46193#pullrequestreview-1247358228 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/46193#pullrequestreview-1247515683 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/46193#pullrequestreview-1249214145 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3923489114 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Jan 15, 2023
MylesBorins
approved these changes
Jan 17, 2023
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I pushed a change to ignore a file with known conflict markers in the npm test suite |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Jan 17, 2023
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Rubber stamp LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@MylesBorins I added the label to squash the commits but if you want the commits to land separately, rebase to put your commit first. |
Sorry, something went wrong.
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
PR-URL: nodejs#46193 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 18, 2023
PR-URL: #46193 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #46193 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
PR-URL: #46193 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9.3.0 (2023-01-12)
Features
Bug Fixes
Documentation
Dependencies