[v18.x backport] src: use CreateEnvironment instead of inlining its code where possible - #46330
Closed
addaleax wants to merge 1 commit into
Closed
[v18.x backport] src: use CreateEnvironment instead of inlining its code where possible#46330addaleax wants to merge 1 commit into
addaleax wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
12 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@juanarbol Are the CI failures here specific to this PR? There’s a lot of fs.watch failures so I assume they’re related to test changes having been backported but not code changes (specifically, 17ae2ab)? |
Sorry, something went wrong.
juanarbol
force-pushed
the
v18.x-staging
branch
from
7351221 to
fcfde34
Compare
January 31, 2023 13:17
addaleax
force-pushed
the
backport-45886-v18.x
branch
from
335f8dc to
466d7e2
Compare
February 9, 2023 17:42
Copy link
Copy Markdown
Member
Author
|
(did a clean rebase to be able to try CI again) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4136947306 |
Sorry, something went wrong.
RafaelGSS
force-pushed
the
v18.x-staging
branch
from
0f29b57 to
5e1f213
Compare
February 16, 2023 22:11
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
approved these changes
Feb 24, 2023
juanarbol
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
We had a number of places in which we created an `Environment` instance by performing each step in `CreateEnvironment` manually. Instead, just call the function itself. PR-URL: nodejs#45886 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
juanarbol
force-pushed
the
backport-45886-v18.x
branch
from
466d7e2 to
481bbb4
Compare
February 24, 2023 00:40
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Feb 25, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Feb 28, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
pushed a commit
that referenced
this pull request
Mar 1, 2023
We had a number of places in which we created an `Environment` instance by performing each step in `CreateEnvironment` manually. Instead, just call the function itself. PR-URL: #45886 Backport-PR-URL: #46330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Mar 2, 2023
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
We had a number of places in which we created an `Environment` instance by performing each step in `CreateEnvironment` manually. Instead, just call the function itself. PR-URL: #45886 Backport-PR-URL: #46330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only difference between the original PR and this is ExitCode::kBootstrapFailure vs. BOOTSTRAP_ERROR.
We had a number of places in which we created an Environment instance by performing each step in CreateEnvironment manually. Instead, just call the function itself.
PR-URL: #45886
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com