FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v18.x backport] crypto: add KeyObject Symbol.toStringTag by panva · Pull Request #46341 · nodejs/node · GitHub

/ node Public

[v18.x backport] crypto: add KeyObject Symbol.toStringTag - #46341

Closed
panva wants to merge 1 commit into
nodejs:v18.x-stagingfrom
panva:backport-46043-to-v18.x
ConversationCommits (1)ChecksFiles changed
Closed

[v18.x backport] crypto: add KeyObject Symbol.toStringTag#46341
panva wants to merge 1 commit into
nodejs:v18.x-stagingfrom
panva:backport-46043-to-v18.x

Conversation

panva commented Jan 24, 2023

Copy link
Copy Markdown
Member

Backports #46043, despite landing cleanly it would be missing ObjectDefineProperties from a previous commit that will not be backported.

nodejs-github-bot commented Jan 24, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

crypto: add KeyObject Symbol.toStringTag
6f6cf28 
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#46341
nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v18.x labels Jan 24, 2023
panva force-pushed the backport-46043-to-v18.x branch from ac03819 to 6f6cf28 Compare January 24, 2023 22:53
panva marked this pull request as ready for review January 24, 2023 22:54
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2023

This comment was marked as outdated.

Sign in to view

panva commented Jan 24, 2023

Copy link
Copy Markdown
Member Author

cc @juanarbol

nodejs-github-bot commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49160/

panva commented Jan 28, 2023

Copy link
Copy Markdown
Member Author

It appears you've got this in v18.x-staging already. 👍 feel free to close as needed.

juanarbol approved these changes Jan 28, 2023
View reviewed changes

juanarbol left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

juanarbol pushed a commit that referenced this pull request Jan 28, 2023
crypto: add KeyObject Symbol.toStringTag
20af657 
PR-URL: #46043
Backport-PR-URL: #46341
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

juanarbol commented Jan 28, 2023

Copy link
Copy Markdown
Member

Landed in 20af657 🎉

juanarbol closed this Jan 28, 2023

panva commented Jan 28, 2023

Copy link
Copy Markdown
Member Author

@juanarbol it's just an empty commit now because you've already had it in staging somehow.

panva deleted the backport-46043-to-v18.x branch January 28, 2023 20:50

juanarbol commented Jan 28, 2023

Copy link
Copy Markdown
Member

Sorry, same as #46340; I'll proceed to delete that 20af657 commit from staging.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL