FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add emit to NodeEventTarget by deokjinkim · Pull Request #46356 · nodejs/node · GitHub

/ node Public

doc: add emit to NodeEventTarget - #46356

Closed
deokjinkim wants to merge 2 commits into
nodejs:mainfrom
deokjinkim:230126_events_nodeeventtarget_emit
ConversationCommits (2)ChecksFiles changed
Closed

doc: add emit to NodeEventTarget#46356
deokjinkim wants to merge 2 commits into
nodejs:mainfrom
deokjinkim:230126_events_nodeeventtarget_emit

Conversation

deokjinkim commented Jan 26, 2023

Copy link
Copy Markdown
Contributor

NodeEventTarget.emit() is not described in document. Plus, make type parameter of removeAllListeners as optional.

Refs: #35851

doc: add emit to NodeEventTarget
81a7ffe 
NodeEventTarget.emit() is not described in document. Plus, make
type parameter of removeAllListeners as optional.

Refs: nodejs#35851
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 26, 2023

deokjinkim commented Jan 26, 2023

Copy link
Copy Markdown
Contributor Author

/cc @nodejs/events

lpinca added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 28, 2023
jasnell reviewed Jan 29, 2023
View reviewed changes
Comment thread doc/api/events.md
remove unnecessary empty lines
fd5e5d4 
Co-authored-by: James M Snell <jasnell@gmail.com>
deokjinkim requested a review from jasnell February 9, 2023 05:18

deokjinkim commented Feb 9, 2023

Copy link
Copy Markdown
Contributor Author

@benjamingr Could you please review this PR because this PR adds document for API you implemented?

benjamingr commented Feb 9, 2023

Copy link
Copy Markdown
Member

@deokjinkim first: feel free to ping me for review whenever :)

Second: NodeEventTarget was @jasnell and a bit of @addaleax , I was a distant third (I did work a bunch on EventTarget just not those parts).

deokjinkim added doc Issues and PRs related to the documentations. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 10, 2023
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 10, 2023

github-actions Bot commented Feb 10, 2023

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/4139956554

deokjinkim added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 10, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023

nodejs-github-bot commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49599/

github-actions Bot mentioned this pull request Feb 18, 2023
Open
32 tasks

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49764/

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49769/

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49796/

deokjinkim removed the needs-ci PRs that need a full CI run. label Feb 20, 2023
deokjinkim added a commit that referenced this pull request Feb 20, 2023
doc: add emit to NodeEventTarget
ac7ef31 
NodeEventTarget.emit() is not described in document. Plus, make
type parameter of removeAllListeners as optional.

Refs: #35851
PR-URL: #46356
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

deokjinkim commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

Landed in ac7ef31

deokjinkim closed this Feb 20, 2023
This was referenced Feb 21, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
doc: add emit to NodeEventTarget
dd66c48 
NodeEventTarget.emit() is not described in document. Plus, make
type parameter of removeAllListeners as optional.

Refs: #35851
PR-URL: #46356
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
doc: add emit to NodeEventTarget
45fccc9 
NodeEventTarget.emit() is not described in document. Plus, make
type parameter of removeAllListeners as optional.

Refs: #35851
PR-URL: #46356
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
jasnell Awaiting requested review from jasnell
+1 more reviewer
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL