test: add getRandomValues return length - #46357
Merged
nodejs-github-bot merged 1 commit intoMay 13, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MrJithil
force-pushed
the
addGetRandomValuesReturnTest
branch
from
e088f32 to
e9d9c3f
Compare
January 26, 2023 03:54
panva
reviewed
Jan 26, 2023
Comment thread
test/parallel/test-webcrypto-random.js
Outdated
MrJithil
force-pushed
the
addGetRandomValuesReturnTest
branch
from
e9d9c3f to
64e8f23
Compare
May 13, 2023 04:34
panva
approved these changes
May 13, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 14, 2023
PR-URL: #46357 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 15, 2023
PR-URL: #46357 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Copy link
Copy Markdown
Contributor
|
This broke the test suite in v18.x-staging - I think it's dependent on another commit that was removed, so it will need to be backported. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test to check the return results getRandomValues