doc: fix wrong location of requestTimeout's default value - #46423
Merged
nodejs-github-bot merged 1 commit intoFeb 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
ShogunPanda
approved these changes
Jan 30, 2023
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
theanarkh
approved these changes
Jan 30, 2023
himself65
approved these changes
Jan 30, 2023
lpinca
approved these changes
Jan 30, 2023
HarshithaKP
approved these changes
Jan 31, 2023
jasnell
approved these changes
Feb 3, 2023
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
Refs: https://nodejs.org/dist/latest-v19.x/docs/api/http.html#serverrequesttimeout PR-URL: #46423 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Refs: https://nodejs.org/dist/latest-v19.x/docs/api/http.html#serverrequesttimeout PR-URL: #46423 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://nodejs.org/dist/latest-v19.x/docs/api/http.html#serverrequesttimeout