process: print versions by sort by himself65 · Pull Request #46428 · nodejs/node · GitHub

I'm trying to use std::pair<name, version_number> then sort and create a new v8::Object

I'm confused that why build CI all crashed today

There was a GitHub issue with tarball sha's today that caused stuff all over the place to break. The rolled it back this afternoon. Pretty sure that's what hit us today.

Could you also add a test?

Could you also add a test?

I will do it later

ive updated the test case

Performance isn't as important here but consider using the same technique for consistency.

I think json_keyvalue(k, v) has no implement for std::string_view

nodejs ci is disabled for now. how can I run it before merge the pr

nodejs ci is disabled for now. how can I run it before merge the pr

You'll have to wait until the embargo is lifted and CI reenabled.

CI: https://ci.nodejs.org/job/node-test-pull-request/49616/

CI: https://ci.nodejs.org/job/node-test-pull-request/49699/

Commit Queue failed

- Loading data for nodejs/node/pull/46428 ✔ Done loading data for nodejs/node/pull/46428 ----------------------------------- PR info ------------------------------------ Title process: print versions by sort (#46428) Author Himself65 (@Himself65) Branch Himself65:20230130-sort-versions -> nodejs:main Labels c++, process, author ready, needs-ci Commits 5 - process: print versions by sort - fixup!: code - fixup!: code - fixup!: format - fixup!: format Committers 1 - himself65 PR-URL: https://github.com/nodejs/node/pull/46428 Fixes: https://github.com/nodejs/node/issues/45630 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46428 Fixes: https://github.com/nodejs/node/issues/45630 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 30 Jan 2023 18:42:25 GMT ✔ Approvals: 3 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46428#pullrequestreview-1304619046 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46428#pullrequestreview-1282238933 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46428#pullrequestreview-1284199496 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-02-18T17:34:16Z: https://ci.nodejs.org/job/node-test-pull-request/49699/ - Querying data for job/node-test-pull-request/49699/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 46428 From https://github.com/nodejs/node * branch refs/pull/46428/merge -> FETCH_HEAD ✔ Fetched commits as 4ba860ee693d..73a1163802da -------------------------------------------------------------------------------- [main 2d9275ad6b] process: print versions by sort Author: himself65 Date: Fri Feb 3 17:04:23 2023 -0600 3 files changed, 42 insertions(+), 9 deletions(-) [main ab24f3f61c] fixup!: code Author: himself65 Date: Fri Feb 3 17:19:54 2023 -0600 2 files changed, 21 insertions(+), 13 deletions(-) [main 66f67104ab] fixup!: code Author: himself65 Date: Sat Feb 4 15:10:17 2023 -0600 1 file changed, 1 insertion(+), 1 deletion(-) [main 881db7bec2] fixup!: format Author: himself65 Date: Sat Feb 4 15:10:32 2023 -0600 1 file changed, 2 insertions(+), 1 deletion(-) [main cb6ee4df18] fixup!: format Author: himself65 Date: Sat Feb 4 15:40:33 2023 -0600 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
process: print versions by sort

Co-authored-by: James M Snell jasnell@gmail.com
Co-authored-by: Anna Henningsen github@addaleax.net
PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

[detached HEAD 6420f6391c] process: print versions by sort
Author: himself65 himself65@toeverything.info
Date: Fri Feb 3 17:04:23 2023 -0600
3 files changed, 42 insertions(+), 9 deletions(-)
Rebasing (3/10)
Rebasing (4/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup!: code

PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

[detached HEAD c4c7d3f07d] fixup!: code
Author: himself65 himself65@toeverything.info
Date: Fri Feb 3 17:19:54 2023 -0600
2 files changed, 21 insertions(+), 13 deletions(-)
Rebasing (5/10)
Rebasing (6/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup!: code

PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

[detached HEAD 5b2476cd8a] fixup!: code
Author: himself65 himself65@toeverything.info
Date: Sat Feb 4 15:10:17 2023 -0600
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (7/10)
Rebasing (8/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup!: format

PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

[detached HEAD e6608b05c5] fixup!: format
Author: himself65 himself65@toeverything.info
Date: Sat Feb 4 15:10:32 2023 -0600
1 file changed, 2 insertions(+), 1 deletion(-)
Rebasing (9/10)
Rebasing (10/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup!: format

PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

[detached HEAD 500f156097] fixup!: format
Author: himself65 himself65@toeverything.info
Date: Sat Feb 4 15:40:33 2023 -0600
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4212781930

Landed in 070246f

Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Anna Henningsen <github@addaleax.net> PR-URL: #46428 Fixes: #45630 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 30, 2023

addaleax reviewed Jan 30, 2023

View reviewed changes

Comment thread src/node_process_object.cc Outdated

himself65 changed the title src: sort version keys process: print versions by sort Jan 30, 2023

himself65 marked this pull request as ready for review January 30, 2023 20:55

himself65 added the process Issues and PRs related to the process subsystem. label Jan 30, 2023

himself65 mentioned this pull request Jan 30, 2023

The version list should be sorted by name #45630

Closed

This comment was marked as outdated.

Sign in to view

himself65 requested a review from addaleax January 30, 2023 21:19

himself65 force-pushed the 20230130-sort-versions branch from fd4a77b to affc744 Compare January 30, 2023 21:28

This comment was marked as outdated.

Sign in to view

addaleax approved these changes Jan 30, 2023

View reviewed changes

Comment thread src/node_process_object.cc Outdated

Comment thread src/node_process_object.cc Outdated

addaleax approved these changes Jan 31, 2023

View reviewed changes

jasnell reviewed Jan 31, 2023

View reviewed changes

Comment thread src/node_process_object.cc Outdated

jasnell approved these changes Jan 31, 2023

View reviewed changes

addaleax reviewed Jan 31, 2023

View reviewed changes

Comment thread src/node_process_object.cc Outdated

addaleax reviewed Jan 31, 2023

View reviewed changes

Comment thread src/node_process_object.cc Outdated

himself65 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 31, 2023

himself65 requested a review from RaisinTen January 31, 2023 16:10

This comment was marked as outdated.

Sign in to view

jasnell approved these changes Feb 3, 2023

View reviewed changes

RaisinTen reviewed Feb 3, 2023

View reviewed changes

Comment thread src/node_process_object.cc Outdated

bnoordhuis reviewed Feb 3, 2023

View reviewed changes

himself65 force-pushed the 20230130-sort-versions branch from cdc159d to a6df4cb Compare February 3, 2023 22:59

himself65 added 3 commits February 11, 2023 10:34

fixup!: code

f3d8794

fixup!: format

aae0ecf

fixup!: format

73a1163

himself65 force-pushed the 20230130-sort-versions branch from 0a314ab to 73a1163 Compare February 11, 2023 16:34

addaleax approved these changes Feb 18, 2023

View reviewed changes

addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 18, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 18, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 18, 2023

nodejs-github-bot merged commit 070246f into nodejs:main Feb 18, 2023

MylesBorins mentioned this pull request Feb 19, 2023

v19.7.0 proposal #46725

Merged

himself65 deleted the 20230130-sort-versions branch February 19, 2023 04:58

anonrig mentioned this pull request Apr 6, 2023

[v18.x backport] replace url parser with ada #47435

Closed

anonrig added the backport-open-v18.x label Apr 6, 2023

danielleadams mentioned this pull request Apr 11, 2023

v18.16.0 release proposal #47502

Merged

richardlau added backported-to-v18.x and removed backport-open-v18.x labels Mar 18, 2024

process: print versions by sort by himself65 · Pull Request #46428 · nodejs/node · GitHub

Uh oh!

Uh oh!

process: print versions by sort - #46428

process: print versions by sort#46428nodejs-github-bot merged 5 commits intonodejs:mainnodejs/node:mainfrom himself65:20230130-sort-versionshimself65/node:20230130-sort-versionsCopy head branch name to clipboard

Conversation

himself65 commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

himself65 commented Jan 30, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

himself65 commented Jan 31, 2023

Uh oh!

jasnell commented Jan 31, 2023

Uh oh!

RaisinTen commented Jan 31, 2023

Uh oh!

himself65 commented Jan 31, 2023

Uh oh!

Uh oh!

Uh oh!

himself65 commented Jan 31, 2023

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

bnoordhuis Feb 3, 2023

Choose a reason for hiding this comment

Uh oh!

himself65 Feb 3, 2023

Choose a reason for hiding this comment

Uh oh!

himself65 commented Feb 13, 2023

Uh oh!

richardlau commented Feb 13, 2023

Uh oh!

nodejs-github-bot commented Feb 17, 2023

Uh oh!

nodejs-github-bot commented Feb 18, 2023

Uh oh!

nodejs-github-bot commented Feb 18, 2023

Co-authored-by: James M Snell jasnell@gmail.com Co-authored-by: Anna Henningsen github@addaleax.net PR-URL: #46428 Fixes: #45630 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #46428 Fixes: #45630 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #46428 Fixes: #45630 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #46428 Fixes: #45630 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #46428 Fixes: #45630 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Darshan Sen raisinten@gmail.com

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Feb 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

process: print versions by sort#46428
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
himself65:20230130-sort-versions

himself65 commented Jan 30, 2023 •
edited
Loading

Co-authored-by: James M Snell jasnell@gmail.com
Co-authored-by: Anna Henningsen github@addaleax.net
PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com