FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v18.x] deps: patch V8 to 10.2.154.26 by targos · Pull Request #46446 · nodejs/node · GitHub

/ node Public

[v18.x] deps: patch V8 to 10.2.154.26 - #46446

Closed
targos wants to merge 1 commit into
nodejs:v18.x-stagingfrom
targos:v8-10.2.154.26
Closed

[v18.x] deps: patch V8 to 10.2.154.26#46446
targos wants to merge 1 commit into
nodejs:v18.x-stagingfrom
targos:v8-10.2.154.26

Conversation

targos commented Jan 31, 2023

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/v8-update

nodejs-github-bot added needs-ci PRs that need a full CI run. v18.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 31, 2023
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

targos commented Feb 5, 2023

Copy link
Copy Markdown
Member Author

Landed in 0f29b57

targos closed this Feb 5, 2023
targos deleted the v8-10.2.154.26 branch February 5, 2023 08:36
targos added a commit that referenced this pull request Feb 5, 2023
Refs: v8/v8@10.2.154.23...10.2.154.26
PR-URL: #46446
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins mentioned this pull request Feb 18, 2023

Copy link
Copy Markdown

FYI: the change in deps/v8/src/compiler/backend/x64/code-generator-x64.cc causes issues on various WebAssembly projects. Cherry-picking commit v8/v8@9ec4e90 would probably fix that. See https://crbug.com/1407594 for details.

targos commented Feb 23, 2023

Copy link
Copy Markdown
Member Author

I wonder if this affects ChromeOS 102. It is still in LTS until Mar 9 2023 so I would expect Google to backport the fix in V8.

Copy link
Copy Markdown
Contributor

@targos what was fixed in this patch, and how important is it for existing 18.4.1 prod deployments?

Copy link
Copy Markdown

For reference, here's a simple reproducer based on the testcase in the above-mentioned V8 commit:

$ curl -LO https://gist.github.com/kleisauke/0084ac571832295019bf5feca99ada02/raw/a42c0cd38f8d402d2a87b9d8017c075be8542767/spiller.wasm
$ node -v
v18.14.1
$ node --noliftoff -e "WebAssembly.instantiate(fs.readFileSync('./spiller.wasm')).then(obj => console.log(obj.instance.exports.main().toString(16)))"
12345678000000
$ node -v
v18.14.2
$ node --noliftoff -e "WebAssembly.instantiate(fs.readFileSync('./spiller.wasm')).then(obj => console.log(obj.instance.exports.main().toString(16)))"
5678000000

(see https://gist.github.com/kleisauke/0084ac571832295019bf5feca99ada02 for the .wat file)

And here's a more complicated reproducer:

Details
$ mkdir wasm-vips-test && cd wasm-vips-test
$ npm init -y
$ npm install wasm-vips
$ curl -LO https://github.com/kleisauke/wasm-vips/raw/master/test/unit/images/sample.png
$ cat <<EOT > test.mjs
import Vips from 'wasm-vips';

const vips = await Vips();

const im = vips.Image.newFromFile('sample.png', {
  fail_on: 'warning'
});
console.log(im.avg());

im.delete();
vips.shutdown();
EOT
$ node -v
v18.14.1
$ node test.mjs
30498.1968091746
$ node -v
v18.14.2
$ node test.mjs
(process:42): VIPS-WARNING **: 17:36:33.618: pngload: invalid scanline filter

(process:42): VIPS-WARNING **: 17:36:33.625: error in tile 0 x 48

...

Error: unable to call avg
pngload: libspng read error

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL