src: back snapshot I/O with a std::vector sink - #46463
Merged
nodejs-github-bot merged 2 commits intoFeb 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
joyeecheung
force-pushed
the
snapshot-io
branch
from
3748eb0 to
d21be77
Compare
February 1, 2023 12:08
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Feb 1, 2023
Comment thread
src/node_snapshotable.cc
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bnoordhuis
approved these changes
Feb 2, 2023
Comment thread
src/node_snapshotable.cc
Outdated
Comment thread
src/node_snapshotable.cc
Outdated
Comment thread
src/node_snapshotable.cc
Outdated
jasnell
approved these changes
Feb 3, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RaisinTen
approved these changes
Feb 3, 2023
legendecas
approved these changes
Feb 3, 2023
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Feb 4, 2023
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: nodejs#46463
22 tasks
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: #46463 PR-URL: #46495 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
This is a shared follow-up to 06bb6b4 and a466fea now that both have been merged. PR-URL: #46491 Refs: #45888 Refs: #46463 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46463 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: #46463 PR-URL: #46495 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
This is a shared follow-up to 06bb6b4 and a466fea now that both have been merged. PR-URL: #46491 Refs: #45888 Refs: #46463 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46463 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: #46463 PR-URL: #46495 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.