FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document how to use the tls.DEFAULT_CIPHERS by andreas-ibm · Pull Request #46482 · nodejs/node · GitHub

/ node Public

doc: document how to use the tls.DEFAULT_CIPHERS - #46482

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
andreas-ibm:dre/doc-ciphers
Feb 23, 2023
ConversationCommits (4)ChecksFiles changed
Merged

doc: document how to use the tls.DEFAULT_CIPHERS#46482
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
andreas-ibm:dre/doc-ciphers

Conversation

andreas-ibm commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

The tls.DEFAULT_CIPHERS var already exists, this change shows how to use it.

Fixes: #46462

I have attempted to keep my changes in style with the rest, I tried finding the Style Guide but the link just sent me back to the top-level README.md so I couldn't find it.

I hope this is helpful!

doc: document how to use the tls.DEFAULT_CIPHERS
c951d3d 
The DEFAULT_CIPHERS already exists, this change shows how to use it.

Fixes: nodejs#46462
nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Feb 3, 2023

andreas-ibm commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

Would it be cheeky to request this goes into v18 too? I don't know how that's done if possible...

richardlau commented Feb 3, 2023

Copy link
Copy Markdown
Member

cc @nodejs/crypto

Would it be cheeky to request this goes into v18 too? I don't know how that's done if possible...

Since Node.js 18 is in active maintenance it should eventually get semver-minor and semver-patch updates once they've gone out in a current release. I'll add the watch label anyway, as it is an extra thing checked when we prepare releases.

andreas-ibm commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

D'oh, forgot the linter gets run in inlined code!
Will fix!

lpinca added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Feb 3, 2023
VoltrexKeyva reviewed Feb 5, 2023
View reviewed changes
Comment thread doc/api/tls.md Outdated
Update doc/api/tls.md
0c6719e 
Remove extraneous quotes

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

andreas-ibm commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

Is there anything I need to do to get this merged?

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2023
nodejs-github-bot merged commit 42be7f6 into nodejs:main Feb 23, 2023

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 42be7f6

andreas-ibm deleted the dre/doc-ciphers branch February 23, 2023 16:38
targos pushed a commit that referenced this pull request Mar 13, 2023
doc: document how to use the tls.DEFAULT_CIPHERS
60d1a48 
The DEFAULT_CIPHERS already exists, this change shows how to use it.

Fixes: #46462
PR-URL: #46482
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
doc: document how to use the tls.DEFAULT_CIPHERS
7e08ca1 
The DEFAULT_CIPHERS already exists, this change shows how to use it.

Fixes: #46462
PR-URL: #46482
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
pimterry mentioned this pull request Aug 29, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
+2 more reviewers
VoltrexKeyva VoltrexKeyva left review comments
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Externalise tls.DEFAULT_CIPHERS please!

8 participants

Back | FazBrowse Home | New Git URL