FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use stricter compile-time guidance by tniessen · Pull Request #46509 · nodejs/node · GitHub

/ node Public

src: use stricter compile-time guidance - #46509

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-snapshotable-getname-constexpr
Apr 4, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: use stricter compile-time guidance#46509
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-snapshotable-getname-constexpr

Conversation

tniessen commented Feb 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

SnapshotSerializerDeserializer::GetName() appears to confuse static analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and marks all branch conditions as constexpr. (Unfortunately, this results in a dangling else keyword in the V macro.)

As a side effect, this change ensures that GetName<T>() can only be called for known types T (instead of returning an empty string). As per a request in the PR discussion, this change does not ensure that GetName<T>() can only be called for known types T and instead still returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.

tniessen added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 5, 2023

nodejs-github-bot commented Feb 5, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 5, 2023

joyeecheung commented Feb 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

As a side effect, this change ensures that GetName() can only be called for known types T (instead of returning an empty string).

Why would this be necessary? This is a debugging facility that decorates the log output, it would be fine to just give up if "I don't know what it's called, so I won't attempt to tell you what the type name is, because RTTI is disallowed" (I think I relied on this when developing deserialization/serialization of new types, which was fine because it's possible to guess the name from the context anyway).

tniessen commented Feb 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Why would this be necessary?

It's certainly not necessary. I can change it to allow unknown types, but unless I'm missing something, I don't really see the point. Wouldn't it only take a one-line change to add new non-arithmetic types?

tniessen commented Feb 19, 2023

Copy link
Copy Markdown
Member Author

@joyeecheung is your comment blocking?

tniessen added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

joyeecheung commented Feb 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Sorry for missing the ping. I wouldn't say it's a hill that I'd die on but it's also weird that this restriction exists. The function is just a utility that attempts to assemble a human-readable name for a type (or it's just poor-man's RTTI). Returning an empty string for a type that we don't special case is totally acceptable. Does the static analyzer complain about it? If it does it would make more sense to do if (!std::is_arithmetic_v<T>) { return ""; /* gives up */ } than adding a static assert.

github-actions Bot mentioned this pull request Feb 20, 2023
Open
24 tasks
joyeecheung mentioned this pull request Feb 20, 2023
Closed
github-actions Bot mentioned this pull request Feb 21, 2023
Open
26 tasks
src: use stricter compile-time guidance
8ddfb52 
SnapshotSerializerDeserializer::GetName() appears to confuse static
analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and
marks all branch conditions as constexpr. (Unfortunately, this results
in a dangling 'else' keyword in the V macro.)

As per a request in the PR discussion, this change does _not_ ensure
that GetName<T>() can only be called for known types T and instead still
returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.
tniessen force-pushed the src-snapshotable-getname-constexpr branch from 451850a to 8ddfb52 Compare March 29, 2023 12:26

tniessen commented Mar 29, 2023

Copy link
Copy Markdown
Member Author

@joyeecheung Sorry about the delay, I've updated the PR as requested. PTAL.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2023

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Mar 30, 2023
Open
18 tasks

This comment was marked as outdated.

Sign in to view
mhdawson approved these changes Mar 30, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50720/

This was referenced Mar 31, 2023
Open
Open
Open
tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
nodejs-github-bot merged commit aa3dbe3 into nodejs:main Apr 4, 2023

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in aa3dbe3

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
src: use stricter compile-time guidance
a4e5ae7 
SnapshotSerializerDeserializer::GetName() appears to confuse static
analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and
marks all branch conditions as constexpr. (Unfortunately, this results
in a dangling 'else' keyword in the V macro.)

As per a request in the PR discussion, this change does _not_ ensure
that GetName<T>() can only be called for known types T and instead still
returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.

PR-URL: #46509
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
src: use stricter compile-time guidance
93392a0 
SnapshotSerializerDeserializer::GetName() appears to confuse static
analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and
marks all branch conditions as constexpr. (Unfortunately, this results
in a dangling 'else' keyword in the V macro.)

As per a request in the PR discussion, this change does _not_ ensure
that GetName<T>() can only be called for known types T and instead still
returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.

PR-URL: #46509
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
src: use stricter compile-time guidance
b748b69 
SnapshotSerializerDeserializer::GetName() appears to confuse static
analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and
marks all branch conditions as constexpr. (Unfortunately, this results
in a dangling 'else' keyword in the V macro.)

As per a request in the PR discussion, this change does _not_ ensure
that GetName<T>() can only be called for known types T and instead still
returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.

PR-URL: #46509
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
src: use stricter compile-time guidance
4405fc8 
SnapshotSerializerDeserializer::GetName() appears to confuse static
analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and
marks all branch conditions as constexpr. (Unfortunately, this results
in a dangling 'else' keyword in the V macro.)

As per a request in the PR discussion, this change does _not_ ensure
that GetName<T>() can only be called for known types T and instead still
returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.

PR-URL: #46509
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
src: use stricter compile-time guidance
52a01e2 
SnapshotSerializerDeserializer::GetName() appears to confuse static
analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and
marks all branch conditions as constexpr. (Unfortunately, this results
in a dangling 'else' keyword in the V macro.)

As per a request in the PR discussion, this change does _not_ ensure
that GetName<T>() can only be called for known types T and instead still
returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.

PR-URL: #46509
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
src: use stricter compile-time guidance
3c28a18 
SnapshotSerializerDeserializer::GetName() appears to confuse static
analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and
marks all branch conditions as constexpr. (Unfortunately, this results
in a dangling 'else' keyword in the V macro.)

As per a request in the PR discussion, this change does _not_ ensure
that GetName<T>() can only be called for known types T and instead still
returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.

PR-URL: #46509
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
src: use stricter compile-time guidance
0fbfb28 
SnapshotSerializerDeserializer::GetName() appears to confuse static
analysis such as Coverity.

This changes the function structure to a sequence of if-else blocks and
marks all branch conditions as constexpr. (Unfortunately, this results
in a dangling 'else' keyword in the V macro.)

As per a request in the PR discussion, this change does _not_ ensure
that GetName<T>() can only be called for known types T and instead still
returns an empty string in that case.

Also use std::is_unsigned_v instead of !std::is_signed_v.

PR-URL: nodejs#46509
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL