src: remove icu usage from node_string.cc - #46548
Merged
nodejs-github-bot merged 1 commit intoFeb 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
force-pushed
the
remove-icu-from-node-string
branch
2 times, most recently
from
7ed8398 to
870e211
Compare
February 7, 2023 22:23
Copy link
Copy Markdown
Member
|
@nodejs/cpp-reviewers |
Sorry, something went wrong.
bnoordhuis
approved these changes
Feb 8, 2023
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with a suggestion.
Sorry, something went wrong.
Comment thread
src/inspector/node_string.cc
Outdated
Trott
previously approved these changes
Feb 8, 2023
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with @bnoordhuis's suggestion
Sorry, something went wrong.
Trott
dismissed
their stale review
February 8, 2023 16:59
I'm going to dismiss my review because it is a bit rubber-stamp-y. This change looks good to me, but my competence in this area is significantly less than that of others who will hopefully review.
anonrig
force-pushed
the
remove-icu-from-node-string
branch
from
870e211 to
210b57e
Compare
February 8, 2023 20:53
Copy link
Copy Markdown
Member
Author
|
@bnoordhuis Can you review it again? |
Sorry, something went wrong.
bnoordhuis
approved these changes
Feb 8, 2023
mhdawson
approved these changes
Feb 9, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jasnell
approved these changes
Feb 11, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46548 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2023
PR-URL: #46548 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
Feb 22, 2023
Many tests started failing on ARM64 Windows after migrating from icu to simdutf. This change reverts those changes for the problematic platform. Refs: nodejs#46471 Refs: nodejs#46472 Refs: nodejs#46548 Refs: simdutf/simdutf#216
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46548 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37954 (comment)
cc @Trott @targos