src: per-realm binding data - #46556
Merged
nodejs-github-bot merged 1 commit intoFeb 21, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
legendecas
force-pushed
the
binding-data
branch
from
cd2001d to
5b2c0f8
Compare
February 8, 2023 07:54
joyeecheung
approved these changes
Feb 8, 2023
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4123606552 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
CI is under security embargo until at least 14 Feb. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yeah, let's wait for the security releases first. |
Sorry, something went wrong.
cjihrig
approved these changes
Feb 9, 2023
mcollina
approved these changes
Feb 9, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
32 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
force-pushed
the
binding-data
branch
from
5b2c0f8 to
0468776
Compare
February 20, 2023 14:27
Copy link
Copy Markdown
Member
Author
|
Rebased on the tip of the main branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
26 tasks
Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed.
legendecas
force-pushed
the
binding-data
branch
from
0468776 to
7aadcd0
Compare
February 21, 2023 17:45
mcollina
approved these changes
Feb 21, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
34 tasks
This was referenced Feb 22, 2023
Copy link
Copy Markdown
Member
|
Could you please backport this into v18.x? |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed. PR-URL: #46556 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
legendecas
added a commit
to legendecas/node
that referenced
this pull request
May 18, 2023
Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed. PR-URL: nodejs#46556 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> # Conflicts: # src/dataqueue/queue.cc
danielleadams
pushed a commit
that referenced
this pull request
May 29, 2023
Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed. PR-URL: #46556 Backport-PR-URL: #47174 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> # Conflicts: # src/dataqueue/queue.cc
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Feb 18, 2025
Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed. PR-URL: nodejs#46556 Backport-PR-URL: nodejs#47174 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> # Conflicts: # src/dataqueue/queue.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.