test,crypto: update WebCryptoAPI WPT - #46575
Closed
panva wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
approved these changes
Feb 8, 2023
lpinca
approved these changes
Feb 8, 2023
VoltrexKeyva
approved these changes
Feb 8, 2023
jasnell
approved these changes
Feb 9, 2023
panva
marked this pull request as draft
February 15, 2023 19:11
Copy link
Copy Markdown
Member
Author
|
I have two upstream WPT PRs open that I'm hoping will get merged soon(ish). When they're merged I'll make this ready again. |
Sorry, something went wrong.
panva
force-pushed
the
wpt-bump-webcrypto
branch
from
ee4b572 to
64ebca5
Compare
February 16, 2023 12:53
panva
marked this pull request as ready for review
February 16, 2023 12:54
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46575 ✔ Done loading data for nodejs/node/pull/46575 ----------------------------------- PR info ------------------------------------ Title test,crypto: update WebCryptoAPI WPT (#46575) Author Filip Skokan (@panva) Branch panva:wpt-bump-webcrypto -> nodejs:main Labels crypto, test, author ready, needs-ci, webcrypto Commits 1 - test,crypto: update WebCryptoAPI WPT Committers 1 - Filip Skokan PR-URL: https://github.com/nodejs/node/pull/46575 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46575 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test,crypto: update WebCryptoAPI WPT ℹ This PR was created on Wed, 08 Feb 2023 17:14:35 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46575#pullrequestreview-1289706439 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46575#pullrequestreview-1289851657 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/46575#pullrequestreview-1289895072 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46575#pullrequestreview-1290259897 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-02-17T06:11:44Z: https://ci.nodejs.org/job/node-test-pull-request/49611/ - Querying data for job/node-test-pull-request/49611/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4204050590 |
Sorry, something went wrong.
panva
added a commit
that referenced
this pull request
Feb 17, 2023
PR-URL: #46575 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46575 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2023
PR-URL: #46575 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46575 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git node wpt WebCryptoAPI