deps: copy postject-api.h and LICENSE to the deps folder - #46582
Closed
RaisinTen wants to merge 2 commits into
Closed
deps: copy postject-api.h and LICENSE to the deps folder#46582RaisinTen wants to merge 2 commits into
RaisinTen wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: nodejs#45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
force-pushed
the
deps/copy-postject-api-and-license-to-the-deps-folder
branch
from
54baca1 to
2c626f5
Compare
February 9, 2023 06:37
Copy link
Copy Markdown
Member
Author
|
Although this has the needs-ci PRs that need a full CI run. label, I'd like to land this PR manually without waiting for a green Jenkins CI because nothing here is actually compiled or tested on the Jenkins CI yet. |
Sorry, something went wrong.
This comment was marked as outdated.
ovflowd
approved these changes
Feb 9, 2023
ovflowd
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Rubber stamp approval :)
Sorry, something went wrong.
anonrig
reviewed
Feb 9, 2023
Comment thread
tools/dep_updaters/update-postject.sh
Comment thread
doc/contributing/maintaining-postject.md
anonrig
reviewed
Feb 9, 2023
Comment thread
tools/dep_updaters/update-postject.sh
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
anonrig
approved these changes
Feb 9, 2023
mhdawson
approved these changes
Feb 9, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
lpinca
approved these changes
Feb 9, 2023
Comment thread
tools/dep_updaters/update-postject.sh
tony-go
approved these changes
Feb 10, 2023
RaisinTen
added a commit
that referenced
this pull request
Feb 11, 2023
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RaisinTen
deleted the
deps/copy-postject-api-and-license-to-the-deps-folder
branch
February 11, 2023 05:08
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since postject-api.h gets compiled into Node.js, it makes more sense to put it in the deps directory instead of test/fixtures.
Refs: #45038 (comment)
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @mhdawson @nodejs/single-executable