FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix negative nodeTiming milestone values by legendecas · Pull Request #46588 · nodejs/node · GitHub

/ node Public

src: fix negative nodeTiming milestone values - #46588

Closed
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:perf_hooks/time_origin
ConversationCommits (2)ChecksFiles changed
Closed

src: fix negative nodeTiming milestone values#46588
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:perf_hooks/time_origin

Conversation

legendecas commented Feb 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Although the performance.timeOrigin is a Web API, Node.js specific extension performance.nodeTiming exposes the process performance milestones in the main thread and the worker threads. In order to avoid exposing negative values in performance.nodeTiming, set the performance.timeOrigin to the start time of the process both in the main thread and worker threads.

Refs: #43781
Fixes #45958, with regression test cases.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 9, 2023

legendecas commented Feb 9, 2023

Copy link
Copy Markdown
Member Author

#43781 didn't land on v14.x and v16.x, so this fix doesn't need to land on v14.x and v16.x too.

addaleax reviewed Feb 9, 2023
View reviewed changes
Comment thread src/env.h Outdated
legendecas force-pushed the perf_hooks/time_origin branch from b318df3 to 6760c9a Compare February 16, 2023 16:55
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49761/

github-actions Bot mentioned this pull request Feb 21, 2023
Open
26 tasks

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49969/

This was referenced Feb 25, 2023
Open
Open
Open
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2023

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50063/

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50065/

github-actions Bot mentioned this pull request Feb 28, 2023
Open
16 tasks

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50082/

legendecas commented Feb 28, 2023

Copy link
Copy Markdown
Member Author

Fixed the test failure with tools/run-worker.js.

This was referenced Mar 1, 2023
Open
Open
legendecas added a commit that referenced this pull request Mar 2, 2023
src: fix negative nodeTiming milestone values
a8c3d03 
PR-URL: #46588
Fixes: #45958
Refs: #43781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

legendecas commented Mar 2, 2023

Copy link
Copy Markdown
Member Author

Landed in a8c3d03

legendecas closed this Mar 2, 2023
legendecas deleted the perf_hooks/time_origin branch March 2, 2023 16:22
targos pushed a commit that referenced this pull request Mar 13, 2023
src: fix negative nodeTiming milestone values
213efa6 
PR-URL: #46588
Fixes: #45958
Refs: #43781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
src: fix negative nodeTiming milestone values
6740679 
PR-URL: #46588
Fixes: #45958
Refs: #43781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos mentioned this pull request Mar 14, 2023
Merged

danielleadams commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

@legendecas this didn't land cleanly on v18.x - do you mind opening a backport PR? Thank you

legendecas commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

#43781 didn't land on v18.x. I'm tagging this as https://github.com/nodejs/node/labels/dont-land-on-v18.x.

coderabbitai Bot mentioned this pull request Aug 10, 2026
Merged
coderabbitai Bot mentioned this pull request Aug 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax left review comments
jasnell jasnell approved these changes
JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PerformanceNodeTiming of perf_hooks

6 participants

Back | FazBrowse Home | New Git URL