stream: fix pipeline callback not called on ended stream - #46600
Merged
nodejs-github-bot merged 3 commits intoFeb 19, 2023
Merged
stream: fix pipeline callback not called on ended stream#46600nodejs-github-bot merged 3 commits into
nodejs-github-bot merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
ronag
reviewed
Feb 10, 2023
Comment thread
lib/internal/streams/pipeline.js
Outdated
ronag
approved these changes
Feb 10, 2023
Copy link
Copy Markdown
Contributor
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4141674136 |
Sorry, something went wrong.
mcollina
approved these changes
Feb 10, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
lpinca
approved these changes
Feb 10, 2023
benjamingr
approved these changes
Feb 10, 2023
jasnell
approved these changes
Feb 11, 2023
cjihrig
approved these changes
Feb 11, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Feb 17, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This comment was marked as outdated.
32 tasks
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
21 tasks
24 tasks
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Feb 27, 2023
Fixes: nodejs#46595 PR-URL: nodejs#46600 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Fixes: #46595 PR-URL: #46600 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Fixes: #46595 PR-URL: #46600 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed case from PR #46226, added tests for ended streams
Fixes: #46595