FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix regex strings in Python tools by josusky · Pull Request #46649 · nodejs/node · GitHub

/ node Public

tools: fix regex strings in Python tools - #46649

Closed
josusky wants to merge 2 commits into
nodejs:mainfrom
josusky:main
Closed

tools: fix regex strings in Python tools#46649
josusky wants to merge 2 commits into
nodejs:mainfrom
josusky:main

Conversation

josusky commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

Strings used to construct regular expressions shall be marked as raw
otherwise newer versions of Python throw "SyntaxError" because of
invalid escape sequences.
Note: this is basically the same thing as #46585

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Feb 14, 2023

cclauss commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

Please rebase on the current main branch.

josusky closed this by deleting the head repository Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL