lib: enforce use of trailing commas in more files - #46655
Merged
aduh95 merged 2 commits intoFeb 16, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Some part of the codebase already use trailing commas, this commit is adding a lint rule to ensure it stays this way. This commit also adds the rule for a few files that were missing only one or two trailing commas.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
juliangruber
approved these changes
Feb 15, 2023
Copy link
Copy Markdown
Contributor
Author
|
/cc @nodejs/linting |
Sorry, something went wrong.
targos
approved these changes
Feb 16, 2023
Copy link
Copy Markdown
Member
|
Are we far from being able to enable it on the whole lib folder? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
17 commits/PRs away :) |
Sorry, something went wrong.
MoLow
approved these changes
Feb 16, 2023
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
Some part of the codebase already use trailing commas, this commit is adding a lint rule to ensure it stays this way. This commit also adds the rule for a few files that were missing only one or two trailing commas. PR-URL: #46655 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2023
Some part of the codebase already use trailing commas, this commit is adding a lint rule to ensure it stays this way. This commit also adds the rule for a few files that were missing only one or two trailing commas. PR-URL: #46655 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Some part of the codebase already use trailing commas, this commit is adding a lint rule to ensure it stays this way. This commit also adds the rule for a few files that were missing only one or two trailing commas. PR-URL: #46655 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some part of the codebase already use trailing commas, this commit is adding a lint rule to ensure it stays this way.
This commit also adds the rule for a few files that were missing only one or two trailing commas.