FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix regex strings in Python tools by Trott · Pull Request #46671 · nodejs/node · GitHub

/ node Public

tools: fix regex strings in Python tools - #46671

Merged
Trott merged 1 commit into
nodejs:mainfrom
Trott:python-patch
Feb 21, 2023
ConversationCommits (1)ChecksFiles changed
Merged

tools: fix regex strings in Python tools#46671
Trott merged 1 commit into
nodejs:mainfrom
Trott:python-patch

Conversation

Trott commented Feb 15, 2023

Copy link
Copy Markdown
Member

Opening this to reland #46585 but this time with the metadata required. Sorry for the mess this has turned out to be for a simple change, @josusky. I hope it's OK that I'm doing this on your behalf. (You're still the author on the commit here.)

nodejs-github-bot commented Feb 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/v8-update

Trott added the python PRs and issues that require attention from people who are familiar with Python. label Feb 15, 2023
nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Feb 15, 2023
Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. labels Feb 15, 2023

github-actions Bot commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. labels Feb 15, 2023
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Feb 16, 2023
gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 16, 2023
tniessen approved these changes Feb 16, 2023
View reviewed changes
Comment thread tools/js2c.py Outdated
Trott added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 16, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023

nodejs-github-bot commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49574/

nodejs-github-bot commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5178/

nodejs-github-bot commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5178/

nodejs-github-bot commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5178/

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49807/

nodejs-github-bot commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49813/

tools: fix regex strings in Python tools
af935fc 
PR-URL: nodejs#46671
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Trott commented Feb 21, 2023

Copy link
Copy Markdown
Member Author

Landed in af935fc

Trott merged commit af935fc into nodejs:main Feb 21, 2023
Trott deleted the python-patch branch February 21, 2023 19:57
This was referenced Feb 22, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
tools: fix regex strings in Python tools
25ccaa7 
PR-URL: #46671
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
tools: fix regex strings in Python tools
f80e93d 
PR-URL: #46671
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
tniessen tniessen approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL