FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add request to hold off publicising sec releases by mhdawson · Pull Request #46702 · nodejs/node · GitHub

/ node Public

doc: add request to hold off publicising sec releases - #46702

Closed
mhdawson wants to merge 1 commit into
nodejs:mainfrom
mhdawson:tweet-clarification
ConversationCommits (1)ChecksFiles changed
Closed

doc: add request to hold off publicising sec releases#46702
mhdawson wants to merge 1 commit into
nodejs:mainfrom
mhdawson:tweet-clarification

Conversation

mhdawson commented Feb 17, 2023

Copy link
Copy Markdown
Member
  • We've often seen tweets go out early before announcement and other parts of the security release complete
  • Make an explicit ask that collorators avoid doing this by gating on the tweet from the Node.js account
  • Releasers would still be free to tweet earlier as they know when the process is complete.

nodejs-github-bot commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

mhdawson added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Feb 17, 2023
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 17, 2023
tniessen approved these changes Feb 17, 2023
View reviewed changes
Comment thread doc/contributing/security-release-process.md Outdated
mcollina approved these changes Feb 17, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

richardlau commented Feb 21, 2023

Copy link
Copy Markdown
Member

There's a typo in the commit message ("collorators").

Also I'm +1 for the ask but I'm not sure any collaborator reads this doc unless they are involved with a security release. I don't really have a suggestion though for where a better place to put this would be.

mhdawson mentioned this pull request Feb 21, 2023
Closed
doc: add request to hold off publicising sec releases
7242478 
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson force-pushed the tweet-clarification branch from 39f0a89 to 7242478 Compare February 22, 2023 14:53

mhdawson commented Feb 22, 2023

Copy link
Copy Markdown
Member Author

@richardlau once we have this documented I'm going to publicise to try to make sure collaborators are aware and in cases where they are not we can point them to this doc so that we improve over time.

mhdawson commented Feb 22, 2023

Copy link
Copy Markdown
Member Author

Fixed the typo in the commit comment.

mhdawson mentioned this pull request Feb 27, 2023
Closed
mhdawson added a commit that referenced this pull request Mar 1, 2023
doc: add request to hold off publicising sec releases
7cb09f4 
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

mhdawson commented Mar 1, 2023

Copy link
Copy Markdown
Member Author

Landed in 7cb09f4

mhdawson closed this Mar 1, 2023
targos pushed a commit that referenced this pull request Mar 13, 2023
doc: add request to hold off publicising sec releases
16d3b9a 
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
doc: add request to hold off publicising sec releases
f9739a8 
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
doc: add request to hold off publicising sec releases
11885a7 
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes
ronag ronag approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
legendecas legendecas approved these changes
BridgeAR BridgeAR approved these changes
aduh95 aduh95 approved these changes
trivikr trivikr approved these changes
marsonya marsonya approved these changes
RafaelGSS RafaelGSS approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL