src: use string_view for report and related code - #46723
Merged
nodejs-github-bot merged 2 commits intoFeb 20, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use `std::string_view` for process.report code and related code, drop a few unnecessary `std::to_string` calls, and use `MaybeStackBuffer` instead of `MallocedBuffer`, all in order to avoid unnecessary heap allocations.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
reviewed
Feb 18, 2023
Comment thread
src/json_utils.h
21 tasks
tniessen
approved these changes
Feb 19, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Feb 19, 2023
24 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Feb 20, 2023
RaisinTen
approved these changes
Feb 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Feb 20, 2023
26 tasks
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Use `std::string_view` for process.report code and related code, drop a few unnecessary `std::to_string` calls, and use `MaybeStackBuffer` instead of `MallocedBuffer`, all in order to avoid unnecessary heap allocations. PR-URL: #46723 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Copy link
Copy Markdown
Member
|
I tried backporting but it didn't land cleanly on my pull request for Ada. #47435 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@juanarbol I removed the dont-land-on-v18.x because I opened a backport for Ada (including this PR) |
Sorry, something went wrong.
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Apr 11, 2023
Use `std::string_view` for process.report code and related code, drop a few unnecessary `std::to_string` calls, and use `MaybeStackBuffer` instead of `MallocedBuffer`, all in order to avoid unnecessary heap allocations. PR-URL: nodejs#46723 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 12, 2023
Use `std::string_view` for process.report code and related code, drop a few unnecessary `std::to_string` calls, and use `MaybeStackBuffer` instead of `MallocedBuffer`, all in order to avoid unnecessary heap allocations. PR-URL: #46723 Backport-PR-URL: #47435 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use std::string_view for process.report code and related code, drop a few unnecessary std::to_string calls, and use MaybeStackBuffer instead of MallocedBuffer, all in order to avoid unnecessary heap allocations.