FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v18.x backport] test: add WPTRunner support for variants and generating WPT reports by panva · Pull Request #46767 · nodejs/node · GitHub

/ node Public

[v18.x backport] test: add WPTRunner support for variants and generating WPT reports - #46767

Closed
panva wants to merge 3 commits into
nodejs:v18.x-stagingfrom
panva:backport-46498-to-v18.x
ConversationCommits (3)ChecksFiles changed
Closed

[v18.x backport] test: add WPTRunner support for variants and generating WPT reports#46767
panva wants to merge 3 commits into
nodejs:v18.x-stagingfrom
panva:backport-46498-to-v18.x

Conversation

panva commented Feb 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Backports #46498, #46778, and #46804 to v18.x.

Enables WPT Report for future v18.x LTS releases.

test: add WPTRunner support for variants and generating WPT reports
8812c56 
PR-URL: nodejs#46498
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Backport-PR-URL: nodejs#46767
nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x labels Feb 22, 2023
panva force-pushed the backport-46498-to-v18.x branch from e55d6bd to 8812c56 Compare February 22, 2023 10:26
panva marked this pull request as ready for review February 22, 2023 10:27
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49877/

anonrig approved these changes Feb 22, 2023
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. wip Issues and PRs that are still a work in progress. and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. wip Issues and PRs that are still a work in progress. labels Feb 22, 2023
panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed wip Issues and PRs that are still a work in progress. labels Feb 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023

This comment was marked as outdated.

Sign in to view
test: fix default WPT titles
5d45158 
PR-URL: nodejs#46778
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Backport-PR-URL: nodejs#46767
panva force-pushed the backport-46498-to-v18.x branch from f88b581 to 5d45158 Compare February 22, 2023 21:52
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Feb 23, 2023
Open
31 tasks
panva marked this pull request as ready for review February 25, 2023 19:35
panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Feb 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50002/

github-actions Bot mentioned this pull request Feb 26, 2023
Open
15 tasks

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50012/

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50022/

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50025/

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50026/

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50034/

panva commented Feb 26, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/backporters if possible, please land 🙏 so that the next v18.x tagged release starts submitting runs to wpt.fyi like nightly and 19.x already do.

This does not affect the build, it merely enables the daily wpt workflow to create the report for future v18.x releases.

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50038/

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50040/

github-actions Bot mentioned this pull request Feb 27, 2023
Open
13 tasks

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50043/

panva mentioned this pull request Feb 27, 2023
Closed
This was referenced Feb 28, 2023
Open
Open
panva mentioned this pull request Mar 3, 2023
Merged
juanarbol removed the needs-ci PRs that need a full CI run. label Mar 5, 2023
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
test: add WPTRunner support for variants and generating WPT reports
5f422c4 
PR-URL: #46498
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Backport-PR-URL: #46767
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
test: fix default WPT titles
162e340 
PR-URL: #46778
Backport-PR-URL: #46767
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
test: fix WPT title when no META title is present
de64315 
PR-URL: #46804
Backport-PR-URL: #46767
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

juanarbol commented Mar 5, 2023

Copy link
Copy Markdown
Member

Landed in 492fc95...de64315

juanarbol closed this Mar 5, 2023
panva deleted the backport-46498-to-v18.x branch March 5, 2023 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL