FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: update CODEOWNERS of url implementations by anonrig · Pull Request #46775 · nodejs/node · GitHub

/ node Public

meta: update CODEOWNERS of url implementations - #46775

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:add-node-url
Feb 24, 2023
Merged

meta: update CODEOWNERS of url implementations#46775
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:add-node-url

Conversation

anonrig commented Feb 22, 2023

Copy link
Copy Markdown
Member

This pull request updates the codeowners document and adds @nodejs/url team to URL related files and dependencies

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 22, 2023
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 22, 2023

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
nodejs-github-bot merged commit b6c56cb into nodejs:main Feb 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in b6c56cb

targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46775
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46775
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

Copy link
Copy Markdown
Contributor

I think this is blocked by #46410

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL