meta: remove unnecessary onboarding step - #46793
Merged
nodejs-github-bot merged 1 commit intoFeb 25, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
While it is nice to notify the TSC about accepted nominations, it is not strictly necessary and I think we should streamline things as much as possible.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
ronag
approved these changes
Feb 23, 2023
aduh95
approved these changes
Feb 23, 2023
cjihrig
approved these changes
Feb 23, 2023
BethGriggs
approved these changes
Feb 23, 2023
RafaelGSS
approved these changes
Feb 23, 2023
legendecas
approved these changes
Feb 23, 2023
mhdawson
approved these changes
Feb 23, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
mcollina
approved these changes
Feb 23, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
tniessen
approved these changes
Feb 23, 2023
richardlau
approved these changes
Feb 23, 2023
trivikr
approved these changes
Feb 24, 2023
RaisinTen
approved these changes
Feb 24, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
While it is nice to notify the TSC about accepted nominations, it is not strictly necessary and I think we should streamline things as much as possible. PR-URL: #46793 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
While it is nice to notify the TSC about accepted nominations, it is not strictly necessary and I think we should streamline things as much as possible. PR-URL: #46793 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it is nice to notify the TSC about accepted nominations, it is not strictly necessary and I think we should streamline things as much as possible.