FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: isolate hr-time specific wpt global init by panva · Pull Request #46795 · nodejs/node · GitHub

/ node Public

test: isolate hr-time specific wpt global init - #46795

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:wpt-hr-time-cleanup
Feb 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: isolate hr-time specific wpt global init#46795
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:wpt-hr-time-cleanup

Conversation

panva commented Feb 23, 2023

Copy link
Copy Markdown
Member

This removes a global scope WPT hack and only adds it to the WPT that needs it (hr-time).

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 23, 2023
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49936/

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49951/

github-actions Bot mentioned this pull request Feb 24, 2023
Open
25 tasks
panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 24, 2023

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49971/

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
github-actions Bot mentioned this pull request Feb 25, 2023
Open
28 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
nodejs-github-bot merged commit 32a907a into nodejs:main Feb 25, 2023

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 32a907a

panva deleted the wpt-hr-time-cleanup branch February 25, 2023 15:59
This was referenced Feb 26, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
test: isolate hr-time specific wpt global init
76a9634 
PR-URL: #46795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos mentioned this pull request Mar 14, 2023
Merged

danielleadams commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

I think this is dependent on #44483

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL