FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove useless WPT init scripts by panva · Pull Request #46801 · nodejs/node · GitHub

/ node Public

test: remove useless WPT init scripts - #46801

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:remove-useless-init-scripts
Feb 25, 2023
Merged

test: remove useless WPT init scripts#46801
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:remove-useless-init-scripts

Conversation

panva commented Feb 23, 2023

Copy link
Copy Markdown
Member

These init scripts are no longer needed, they're setting globals which are already globals in v18.x

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 23, 2023
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 23, 2023
lpinca added dont-land-on-v14.x author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backport-blocked-v14.x labels Feb 23, 2023
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
nodejs-github-bot merged commit 2e5cb5b into nodejs:main Feb 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2e5cb5b

panva deleted the remove-useless-init-scripts branch February 25, 2023 17:21
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46801
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46801
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46801
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL