tools: upload daily WPT Report to both staging and production - #46803
Merged
nodejs-github-bot merged 1 commit intoFeb 25, 2023
Merged
tools: upload daily WPT Report to both staging and production#46803nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
richardlau
reviewed
Feb 23, 2023
Comment thread
.github/workflows/daily-wpt-fyi.yml
richardlau
approved these changes
Feb 23, 2023
anonrig
approved these changes
Feb 23, 2023
This comment was marked as outdated.
bnb
approved these changes
Feb 23, 2023
bnb
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Action LGTM
Sorry, something went wrong.
jasnell
approved these changes
Feb 24, 2023
aymen94
approved these changes
Feb 24, 2023
Copy link
Copy Markdown
Member
Author
|
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46803 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46803 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion with the wpt.fyi API maintainers, it is advisable to submit to both staging and production systems, given the credentials are the same for both environments this requires no addition to our secrets.
When done we can remove the WPT_FYI_ENDPOINT repo variable from nodejs/node and nodejs/node-auto-test.