FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update simdutf to 3.2.2 by nodejs-github-bot · Pull Request #46841 · nodejs/node · GitHub

/ node Public

deps: update simdutf to 3.2.2 - #46841

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-simdutf
Mar 1, 2023
ConversationCommits (1)ChecksFiles changed
Merged

deps: update simdutf to 3.2.2#46841
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-simdutf

Conversation

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of simdutf to 3.2.2.

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Feb 26, 2023
aduh95 reviewed Feb 26, 2023
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The diff is suspiciously small, is the workflow working as expected? 🤔

anonrig commented Feb 26, 2023

Copy link
Copy Markdown
Member

The diff is suspiciously small, is the workflow working as expected? 🤔

Yes, the change was related to performance counters, but its not included in the singleheader deployment of simdutf. cc @lemire

lemire commented Feb 26, 2023

Copy link
Copy Markdown
Member

Right. It is a version bump that fixes a very specific issue that affected brew maintainers.

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/50037/

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 26, 2023
anonrig requested a review from aduh95 February 26, 2023 20:17

lpinca commented Mar 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I think we can skip this update, no? It's only noise.

I guess it will be picked up again when the workflow runs.

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
nodejs-github-bot merged commit 55c944e into main Mar 1, 2023
nodejs-github-bot deleted the actions/tools-update-simdutf branch March 1, 2023 21:01

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 55c944e

targos pushed a commit that referenced this pull request Mar 13, 2023
deps: update simdutf to 3.2.2
5d2a673 
PR-URL: #46841
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
deps: update simdutf to 3.2.2
fb1ac98 
PR-URL: #46841
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
deps: update simdutf to 3.2.2
73be4f8 
PR-URL: #46841
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL