doc: fix stream iterator helpers examples - #46897
Merged
nodejs-github-bot merged 1 commit intoMar 1, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MoLow
approved these changes
Mar 1, 2023
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
Sorry, something went wrong.
MoLow
force-pushed
the
benjamingr-improve-stream-docs
branch
from
f03fb05 to
04bf7dc
Compare
March 1, 2023 14:43
Copy link
Copy Markdown
Member
|
I have amended the commit message since @benjamingr cannot from his phone |
Sorry, something went wrong.
MoLow
force-pushed
the
benjamingr-improve-stream-docs
branch
from
04bf7dc to
d9e47f1
Compare
March 1, 2023 14:45
Copy link
Copy Markdown
Member
Author
Thanks, I enjoy the irony of having a typo of an "s" on a PR that fixes a typo of an "s". Also I have a laptop here just a shitty one (not mine) without Node built ^^ |
Sorry, something went wrong.
ronag
approved these changes
Mar 1, 2023
debadree25
approved these changes
Mar 1, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46897 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46897 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46897 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our examples don't run because of a typo and when I asked for feedback on something unrelated I got told that :)
Trying to create a PR from the GitHub UI since I am OOO for a bit. I haven't done a PR from GH in a while so hopefully it's not too much trouble
cc @MoLow @ronag @nodejs/streams