FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve test coverage of lib/dns by paivaandeerson · Pull Request #46910 · nodejs/node · GitHub

/ node Public

test: improve test coverage of lib/dns - #46910

Merged
Trott merged 1 commit into
nodejs:mainfrom
paivaandeerson:test-improve-coverage-lib-dns
Mar 7, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: improve test coverage of lib/dns#46910
Trott merged 1 commit into
nodejs:mainfrom
paivaandeerson:test-improve-coverage-lib-dns

Conversation

paivaandeerson commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 2, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
anonrig reviewed Mar 2, 2023
View reviewed changes
Comment thread test/parallel/test-dns.js Outdated
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023

nodejs-github-bot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50162/

benjamingr reviewed Mar 2, 2023
View reviewed changes
Comment thread test/parallel/test-dns.js Outdated
benjamingr reviewed Mar 2, 2023
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good job and welcome!

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 2, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023

nodejs-github-bot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50166/

nodejs-github-bot commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50191/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 3, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 4, 2023

nodejs-github-bot commented Mar 4, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46910
✔  Done loading data for nodejs/node/pull/46910
----------------------------------- PR info ------------------------------------
Title      test: improve test coverage of lib/dns (#46910)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     paivaandeerson:test-improve-coverage-lib-dns -> nodejs:main
Labels     test, author ready, needs-ci, commit-queue-squash
Commits    4
 - test: improve test coverage of lib/dns
 - test: improve test coverage of lib/dns
 - Merge branch 'test-improve-coverage-lib-dns' of github.com:paivaandee…
 - message removed in expected exception
Committers 1
 - Anderson Paiva 
PR-URL: https://github.com/nodejs/node/pull/46910
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46910
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 02 Mar 2023 11:27:53 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46910#pullrequestreview-1322500567
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46910#pullrequestreview-1322504421
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2023-03-03T17:33:01Z: https://ci.nodejs.org/job/node-test-pull-request/50191/
- Querying data for job/node-test-pull-request/50191/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4330782924

debadree25 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 4, 2023

debadree25 commented Mar 4, 2023

Copy link
Copy Markdown
Contributor

Will the merge commit cause any issue in commit queue?

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 6, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 6, 2023

nodejs-github-bot commented Mar 6, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46910
✔  Done loading data for nodejs/node/pull/46910
----------------------------------- PR info ------------------------------------
Title      test: improve test coverage of lib/dns (#46910)
Author     Anderson Paiva  (@paivaandeerson, first-time contributor)
Branch     paivaandeerson:test-improve-coverage-lib-dns -> nodejs:main
Labels     test, author ready, needs-ci, commit-queue-squash
Commits    4
 - test: improve test coverage of lib/dns
 - test: improve test coverage of lib/dns
 - Merge branch 'test-improve-coverage-lib-dns' of github.com:paivaandee…
 - message removed in expected exception
Committers 1
 - Anderson Paiva 
PR-URL: https://github.com/nodejs/node/pull/46910
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46910
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 02 Mar 2023 11:27:53 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46910#pullrequestreview-1322500567
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46910#pullrequestreview-1322504421
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2023-03-04T11:33:21Z: https://ci.nodejs.org/job/node-test-pull-request/50191/
- Querying data for job/node-test-pull-request/50191/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4346530808

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 7, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 7, 2023

nodejs-github-bot commented Mar 7, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46910
✔  Done loading data for nodejs/node/pull/46910
----------------------------------- PR info ------------------------------------
Title      test: improve test coverage of lib/dns (#46910)
Author     Anderson Paiva  (@paivaandeerson, first-time contributor)
Branch     paivaandeerson:test-improve-coverage-lib-dns -> nodejs:main
Labels     test, author ready, needs-ci, commit-queue-squash
Commits    4
 - test: improve test coverage of lib/dns
 - test: improve test coverage of lib/dns
 - Merge branch 'test-improve-coverage-lib-dns' of github.com:paivaandee…
 - message removed in expected exception
Committers 1
 - Anderson Paiva 
PR-URL: https://github.com/nodejs/node/pull/46910
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46910
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 02 Mar 2023 11:27:53 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46910#pullrequestreview-1322500567
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46910#pullrequestreview-1322504421
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2023-03-06T18:10:14Z: https://ci.nodejs.org/job/node-test-pull-request/50191/
- Querying data for job/node-test-pull-request/50191/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4349455472

Trott commented Mar 7, 2023

Copy link
Copy Markdown
Member

Will the merge commit cause any issue in commit queue?

Probably. Merge commits have caused issues with our tooling in the past. I'd suggest rebasing this to get rid of the merge commit and then force push. But at this point, to avoid having to run CI again, etc. I'll land it manually and remove the merge commit during that process.

test: improve test coverage of lib/dns
ab9b467 
PR-URL: nodejs#46910
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Trott force-pushed the test-improve-coverage-lib-dns branch from 5402bf4 to ab9b467 Compare March 7, 2023 02:01
Trott merged commit ab9b467 into nodejs:main Mar 7, 2023

Trott commented Mar 7, 2023

Copy link
Copy Markdown
Member

Landed in ab9b467. Thanks for the contribution! 🎉

debadree25 mentioned this pull request Mar 12, 2023
Closed
2 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
test: improve test coverage of lib/dns
1df6c20 
PR-URL: #46910
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
test: improve test coverage of lib/dns
acfd9b8 
PR-URL: #46910
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
test: improve test coverage of lib/dns
b8cdd15 
PR-URL: #46910
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL