debugger: fix behavior of { a: 1 } in the debugger repl - #46924
Closed
meixg wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
BridgeAR
reviewed
Mar 3, 2023
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The change itself is LGTM. I think we should add a test though?
Sorry, something went wrong.
jenthone
reviewed
Mar 3, 2023
Comment thread
lib/internal/debugger/inspect_repl.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think we also should append lib/internal/debugger/inspect_repl.js to this comment:
Lines 417 to 421 in 31156a7
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #46808