FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove use of SSL_OP_SINGLE_DH_USE by tniessen · Pull Request #46955 · nodejs/node · GitHub

/ node Public

src: remove use of SSL_OP_SINGLE_DH_USE - #46955

Closed
tniessen wants to merge 0 commit into
nodejs:mainfrom
tniessen:src-remove-SSL_OP_SINGLE_DH_USE
ConversationCommits (0)ChecksFiles changed
Closed

src: remove use of SSL_OP_SINGLE_DH_USE#46955
tniessen wants to merge 0 commit into
nodejs:mainfrom
tniessen:src-remove-SSL_OP_SINGLE_DH_USE

Conversation

tniessen commented Mar 4, 2023

Copy link
Copy Markdown
Member

This option does not have any effect in any supported OpenSSL version.

Refs: #46954

tniessen added the openssl Issues and PRs related to the OpenSSL dependency. label Mar 4, 2023

nodejs-github-bot commented Mar 4, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 4, 2023
tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 4, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 4, 2023

nodejs-github-bot commented Mar 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50201/

tniessen added the tls Issues and PRs related to the tls subsystem. label Mar 4, 2023
bnoordhuis approved these changes Mar 5, 2023
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For posterity: SSL_OP_SINGLE_DH_USE is always zero nowadays, i.e., a no-op.

panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 5, 2023

nodejs-github-bot commented Mar 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50206/

tniessen added a commit that referenced this pull request Mar 9, 2023
src: remove use of SSL_OP_SINGLE_DH_USE
ef454c8 
This option does not have any effect in any supported OpenSSL version.

Refs: #46954
PR-URL: #46955
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
tniessen closed this Mar 9, 2023
tniessen force-pushed the src-remove-SSL_OP_SINGLE_DH_USE branch from 1332e1e to ef454c8 Compare March 9, 2023 11:26
tniessen deleted the src-remove-SSL_OP_SINGLE_DH_USE branch March 9, 2023 11:27

tniessen commented Mar 9, 2023

Copy link
Copy Markdown
Member Author

Landed in ef454c8.

targos pushed a commit that referenced this pull request Mar 13, 2023
src: remove use of SSL_OP_SINGLE_DH_USE
9b7d39f 
This option does not have any effect in any supported OpenSSL version.

Refs: #46954
PR-URL: #46955
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
src: remove use of SSL_OP_SINGLE_DH_USE
b051ac7 
This option does not have any effect in any supported OpenSSL version.

Refs: #46954
PR-URL: #46955
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
src: remove use of SSL_OP_SINGLE_DH_USE
a4a433f 
This option does not have any effect in any supported OpenSSL version.

Refs: #46954
PR-URL: #46955
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
bnoordhuis bnoordhuis approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL